search

BDNYC / sedkit

Spectral energy distribution construction and analysis tools
https://sedkit.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
18 stars 13 forks source link

Save index.p to users cache location #117

Open kelle opened 3 weeks ago

kelle commented 3 weeks ago

Index.p is a cache file that's used to increase performance.

I think we should add to the .gitignore or learn how to use the computers cache location.

kelle commented 3 weeks ago

https://stackoverflow.com/questions/55395893/is-there-a-standard-location-to-store-function-cache-files-in-python

https://platformdirs.readthedocs.io/en/latest/api.html#cache-directory

SherelynA commented 3 weeks ago

ooh this looks nice but a bit confusing, so we would be adding this to our scripts or?

kelle commented 3 weeks ago

We would modify the package to write the cache somewhere on the users computer rather than in the root directory of the package.

kelle commented 3 weeks ago

This is where it would be changed in the code: https://github.com/BDNYC/sedkit/blob/4d43733bfc284c54bccc564fc97e681ff01caa46/sedkit/modelgrid.py#L475

SherelynA commented 1 day ago

I still have this index.p in my changes, should it be okay to do something like rollback or what would y'all recommend on dealing with this file.

kelle commented 1 day ago

ignore it. Don't add it to any commits. I thought I added to the .gitignore but you can try adding it to yours as well.

On Sun, Nov 24, 2024 at 7:47 PM Sherelyn Alejandro @.***> wrote:

I still have this index.p in my changes, should it be okay to do something like rollback or what would y'all recommend on dealing with this file.

— Reply to this email directly, view it on GitHub https://github.com/BDNYC/sedkit/issues/117#issuecomment-2496510379, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALATGJKS7CSTDURRD766JD2CJ6RZAVCNFSM6AAAAABQ6XVUF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJWGUYTAMZXHE . You are receiving this because you authored the thread.Message ID: @.***>