search

BDNYC / sedkit

Spectral energy distribution construction and analysis tools
MIT License
17 stars 13 forks source link

Error Propagation for fbol #38

Closed ECGonzales closed 3 years ago

ECGonzales commented 5 years ago

Fix the error propagation for fbol. Problem is likely the conversion of the error formula into code.

hover2pi commented 4 years ago

I think this is fixed? @ECGonzales is there still a problem? If so can you detail it here for posterity? Thanks!

ECGonzales commented 4 years ago

@hover2pi No it is not fixed, as I'm not sure how to properly address it in SEDkit. I have been doing a work around, where I add/subtract the uncertainty of the photometry points and make those two SEDs therefore I have conservative errors. Using the upper and lower SEDs I use the difference for the uncertainty and propagate that for the new Teff uncertainty.

hover2pi commented 3 years ago

This is closely related to Issue #12 and I'll make sure uncertainties are propagated properly across all quantities when I implement a new error model in the next release.

hover2pi commented 3 years ago

I think this is finally fixed in #68 !