search

BDNYC / sedkit

Spectral energy distribution construction and analysis tools
MIT License
16 stars 13 forks source link

Teff with and without optical spectra #78

Closed graceparkk closed 1 year ago

graceparkk commented 2 years ago

Hello again! Before putting in the optical spectra, the uncertainty for Teff seems right. However, after adding the optical spectra, the uncertainty for Teff becomes funky. Not only the Teff uncertainty but Lbol uncertainty also becomes nan. Is there a reason behind this?

Screen Shot 2022-08-17 at 8 47 29 PM

^ this is without optical spectra

Screen Shot 2022-08-17 at 8 46 49 PM

^ this is with optical spectra

Thanks!

hover2pi commented 2 years ago

I'm having trouble reproducing this issue @graceparkk . I suspect it's the spectrum file or the way the spectrum is being ingested. I'll email you about it.

SherelynA commented 2 years ago

I am also having an issue like this when adding an optical spectrum. The spectrum was added using s.add_spectrum(). Any further thoughts on what could be happening ?

hover2pi commented 2 years ago

I suspect this is from something in the input spectrum that isn't being processed correctly. The code scrubs NaNs, negatives, zeros, and infs before combining spectra but might ba having a problem. I'll take a look at this for the next release!

hover2pi commented 1 year ago

Appears to be fixed in #83 . Submit a new issue if the problem persists in that version!