search

BDX-town / Mangane

Alternative frontend for Akkoma
https://bdx.town
GNU Affero General Public License v3.0
156 stars 27 forks source link

feat: Add Default post language configuration option #312

Closed last-partizan closed 4 months ago

last-partizan commented 7 months ago

This PR adds option to specify posting language.

Currently, this is exposed only in settings. Next step is to add component to compose form (probably it's best left for another PR, if someone can suggest what widgets i can use for this).

This is my first time working with React, please review it carefully.

Refs #171

Cl0v1s commented 7 months ago

Thanks a lot for your work there ! I'm working on my side on a language selector for the compose UI so both of those PR are complementary, that's good news !

I have a question noneless for a better understanding: why do you add a language and default_language in app/soapbox/reducers/compose.ts ?

last-partizan commented 7 months ago

Because other fields have similar "value" and "default_value" variables. (I think, we can use to check if value has changed, but right now it's unused).

But i may not be necessary. Should i leave it, or maybe better remove now, and add only when it's necessary?

Cl0v1s commented 5 months ago

No that's fine, let's keep it for now !