search

BDisp / unlocker

VMware Workstation macOS
MIT License
946 stars 160 forks source link

get universal repo + kill vm processes #28

Closed juniormayhe closed 1 year ago

juniormayhe commented 1 year ago

@BDisp hi, this pull request promotes two improvements.

Tested locally with vmware workstation pro 16 in Windows. It could be interesting to test this branch on linux.

BDisp commented 1 year ago

@BDisp hi, this pull request promotes two improvements.

Thanks for your contribution.

* try to fetch from [universal repo](http://softwareupdate.vmware.com/cds/vmw-desktop/fusion/13.0.1/21139760/universal/core/) as fallback

I didn't realized that there are new updated tools. I already planed in a next release to remove all the code with all the olds links to get the tools. The gettools always get the last version, as I think is the correct behavior. So, if some VMware Workstation version isn't compatible with the latest darwin.iso tools, the user must update to new vmware version or download and extract the tools manually. If you know what I'm talk about and you still wants to make the changes, feel free to do it.

* kill vm processes by using psutil which seems to be cross platform. `psutil` must be installed in dev env.

I prefer maintain the execution by batch mode without install more dependencies, specially on windows. Is there any problem or error with the kill process with win-install.cmd or lnx-install.sh?

Tested locally with vmware workstation pro 16 in Windows. It could be interesting to test this branch on linux.

I have the VMware Workstation Pro 17.

BDisp commented 1 year ago

Superseded by the #29. Thanks for your contribution but as you seen in my PR I already wanted to make a bigger change. Your feature for kill vmware process actually isn't necessary. So closing this.