BDonnot / ChroniX2Grid

https://chronix2grid.readthedocs.io/en/latest/?
Mozilla Public License 2.0
18 stars 5 forks source link

Make sure the "integration tests" (the notebook) are run #2

Closed BDonnot closed 4 years ago

BDonnot commented 4 years ago

The notebook GetGridGenLoadRenewables.ipynb aims at making sure we can use efficiently, and without having to worry too much about the "side" effect of the modifications of chronix2grid.

I noticed some bug in the module, still under development so that's fine.

But, you introduce some heavy regression: you modified the output of the program, and now grid2op environment cannot be loaded with the ouput of chronix2grid (and worst i was told the exact opposite by mail when I warned this would happened). Avoiding this kind of issue was precisely the goal of the notebook GetGridGenLoadRenewables.ipynb ...

An opportunity to test for real chronix2grid is, because of that, missed. A example challenge is being calibrated. I wanted to use chronix2grid to do the full stack, including the data generation, the calibration of the environment, the training of baselines and the creation of the competition in codalab. Only part of the stack can be tested.