BEAST-Fitting / SEDFitting-outdated

Proto-BEAST code (superseded by the beast)
4 stars 2 forks source link

max_likelihood in wrong place in some lines of fit_seds.pro #11

Closed davidwhogg closed 11 years ago

davidwhogg commented 11 years ago

I think these lines are not right in the placement of the "- max_likelihood" because it is outside the exp(), right?

    if (bmass_ri[i] NE bmass_ri[i+1]) then begin
        bmass_likelihood[i] = alog(total(exp(log_likelihood[good_model_indxs[bmass_ri[bmass_ri[i]:bmass_ri[i+1]-1]]]) $
                                         - max_likelihood)) + max_likelihood
    endif else bmass_likelihood[i] = -75.
endfor
; current mass
for i = 0,(mass_nbins-1) do begin
    if (mass_ri[i] NE mass_ri[i+1]) then begin
        mass_likelihood[i] = alog(total(exp(log_likelihood[good_model_indxs[mass_ri[mass_ri[i]:mass_ri[i+1]-1]]]) $
                                         - max_likelihood)) + max_likelihood
    endif else mass_likelihood[i] = -75.
endfor
; age
for i = 0,(age_nbins-1) do begin
    if (age_ri[i] NE age_ri[i+1]) then begin
        age_likelihood[i] = alog(total(exp(log_likelihood[good_model_indxs[age_ri[age_ri[i]:age_ri[i+1]-1]]]) $
                                         - max_likelihood)) + max_likelihood
    endif else age_likelihood[i] = -75.
karllark commented 11 years ago

Great catch (bloody parentheses)! Fixed.