search

BEAST-Fitting / beast

Bayesian Extinction And Stellar Tool
http://beast.readthedocs.io
23 stars 34 forks source link

Consider dust_extinction package #259

Open karllark opened 6 years ago

karllark commented 6 years ago

We could use the dust_extinction package that has been recently developed and is now an astropy affiliated package. I was the lead of this development. This would provide the same plus additional dust extinction models for the BEAST. In addition the testing and vetting has been more rigorous for this package than the current BEAST dust extinction code. Some work on the interface would be needed.

https://github.com/karllark/dust_extinction

lcjohnso commented 5 years ago

I have interest in this: it would be great to be able to use the Fitzpatrick+04 curve, whereas only the Fitzpatrick+99 curve is currently available in the BEAST code.

I see the work breaking down into three phases: 1) Start including previously unsupported dust curve models in the BEAST codebase. 2) Replace current dust models with versions from the dust_extinction package to reduce maintenance load. 3) Allow the use of any dust_extinction model via keyword/parameter call, without requiring definition in BEAST code.

I am starting work on the first of these three phases with hopes that lays much of the ground work for the latter two.

lcjohnso commented 5 years ago

I made progress on this Issue -- see PR https://github.com/BEAST-Fitting/beast/pull/300.

I accomplished phases 1 and 3 (as listed in the comment above) in this PR, but stopped short of replacing existing code (phase 2).

lcjohnso commented 5 years ago

After PR https://github.com/BEAST-Fitting/beast/pull/300, the remaining work to make a full transition to sole use of the dust_extinction package can be summed up by the following:

  1. Remove old extinction curve code.
  2. Update extinction curve calls in datamodel.py to reflect use of new dust_extinction functions.
karllark commented 4 years ago

Should be pretty easy to finish this, but will require updating the regression testing once the old code is removed and we move to using the dust_extinction provided models even for the G16 model.