search

BEAST-Fitting / beast

Bayesian Extinction And Stellar Tool
http://beast.readthedocs.io
22 stars 34 forks source link

adding in ACS SBC, WFC3 and ACS narrow, and JWST filters and enhancing the filter plotting routine #799

Closed karllark closed 1 month ago

karllark commented 4 months ago

Adding HST HRC FUV filters. Adding in HST WFC3 narrow band filters. Adding JWST NIRCam, NIRISS, and MIRI filters. Added in code to make the vega.hd5 file after making the filters.hd5 file. (thanks @galaxyumi for the code to start from for this). Added test to ensure the filters.hd5 and vega.hd5 are consistent (e.g. have the same filters).

Added new doc file with plots of all the filters. This replaces the text list of filter names.

Filters and vega library files updated in both locations for download (i.e., get_libfiles.py and box location).

Closes #757 Closes #796 Closes #786 Closes #809

karllark commented 4 months ago

Also adding in a couple of WFC3 narrow band filters to support other work.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 16.89189% with 123 lines in your changes are missing coverage. Please review.

Project coverage is 42.04%. Comparing base (08a232b) to head (b683663). Report is 8 commits behind head on master.

:exclamation: Current head b683663 differs from pull request most recent head c9590a5

Please upload reports for the commit c9590a5 to get more accurate results.

Files Patch % Lines
beast/tools/make_libfile.py 4.68% 122 Missing :warning:
beast/plotting/plot_filters.py 94.11% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #799 +/- ## ========================================== - Coverage 42.44% 42.04% -0.41% ========================================== Files 108 108 Lines 10132 10267 +135 ========================================== + Hits 4301 4317 +16 - Misses 5831 5950 +119 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

karllark commented 1 month ago

Visually confirmed that the new and old filters are very similar. The differences seen in the tests must be due to very small changes in the filter band profiles. This was check for HST_ACS_WFC_F475W that is the first failure in the regression tests.

The regression tests files need to be updated to account for these very small changes.