BEAST-Fitting / megabeast

Hierarchical Bayesian Model for Ensembles of Dust Extinguished Stellar Populations
http://megabeast.readthedocs.io/
2 stars 11 forks source link

move beast_data.py to the BEAST repo #40

Closed lea-hagen closed 4 years ago

lea-hagen commented 4 years ago

The BEAST needs the functions that were in beast_data.py to read in the noise/SED/lnP files, so I've moved it there. This PR deletes beast_data.py, and in the places where it was used (megabeast.py and plot_import_data.py), imports beast.tools.read_beast_data instead.

This should not be merged until BEAST-Fitting/beast#468 is merged.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 67


Changes Missing Coverage Covered Lines Changed/Added Lines %
megabeast/megabeast.py 1 8 12.5%
megabeast/plot_input_data.py 1 9 11.11%
<!-- Total: 2 17 11.76% -->
Files with Coverage Reduction New Missed Lines %
megabeast/megabeast.py 4 16.33%
megabeast/plot_input_data.py 4 6.45%
<!-- Total: 8 -->
Totals Coverage Status
Change from base Build 64: -2.1%
Covered Lines: 45
Relevant Lines: 300

💛 - Coveralls
lea-hagen commented 4 years ago

I just did a manual rebase (it couldn't merge automatically after blackening in #41), so this can be merged once https://github.com/BEAST-Fitting/beast/pull/493 is merged.

lgtm-com[bot] commented 4 years ago

This pull request introduces 3 alerts when merging e3a57cbfaec928913f5df5085ad9413ee1358bb2 into 267514c9a31be2487abeda3fac5ca2a82fdb2ff5 - view on LGTM.com

new alerts:

karllark commented 4 years ago

Needs a minor update to the docs to remove the api build for beast_data.

lea-hagen commented 4 years ago

Needs a minor update to the docs to remove the api build for beast_data.

Where do I make that change? I haven't done anything with the api before, and I didn't find anything obvious in the code/docs.

karllark commented 4 years ago

It is at the end of the docs/index.rst file.

lea-hagen commented 4 years ago

Thanks! Just removed it.