BEAST2-Dev / bdsky

Birth Death Serial Skyline Model for BEAST2
GNU General Public License v3.0
2 stars 11 forks source link

BEAUTi: missing Tree prior parameters when switching between templates #32

Closed jugne closed 2 weeks ago

jugne commented 3 weeks ago

When switching between prior templates of BDSky, Tree parameters are not updated correctly.

To reproduce with version 2.7.7:

~Coalescent templates seem to handle switching correctly, maybe that helps to narrow it down.~ Coalescent handles it because the different parameterisations are in separate classes.

jugne commented 3 weeks ago

This is due to different parameters in suppressInputs for different templates. Could be fixed if using ParameterizedBirthDeathSkylineModel instead of BirthDeathSkylineModel.

Possibly there is another workaround..

jugne commented 2 weeks ago

Fixed on BEAUTi side by https://github.com/CompEvol/BeastFX/pull/89