BEEmod / BEE2-items

Standard Items for the BEE2.4
132 stars 46 forks source link

More flexible singular Signage #3940

Open Konclan opened 3 years ago

Konclan commented 3 years ago

Description of the feature

Instead of having pre-defined second signages, signages should be split into primary and secondary for each. This will give players more customizability and also remove (if any) unnecessary duplicate combinations.

Why should this be implemented

Signage is limited, you only have so many preset options and sometimes you need a very specific combination.

Additional information

No response

TeamSpen210 commented 3 years ago

@Critfish suggested instead that the item becomes an entirely singular item, showing a single sign. The arrow would become one of the timer options, and we'd add an angle property to allow rotating + one checkbox to offset. That would allow covering the whole tile, and fully showing all positions.

This does require considering how to transition from existing items, I'd need to keep support for backwards compatibility since the sign is fundamentally changed.

LautaroL20 commented 2 years ago

Transfering some of the Critifish´s comment suggestions about this item (https://github.com/BEEmod/BEE2-items/issues/4127) to here:

Description of the feature

"Make the Signages like quarter tiles, with light strip handle and "cube type" for four individual orientations, then have "start reversed" to make the signage face the other way."

Why should this be implemented

"This way you can effectively (unfortunately with some finagling, but this is the best we can do) position any signage in any position on a surface facing any direction you want. With this method, it'll be easier to do certain signage combinations and would generally be an improvement over the current system."

Additional information

"I feel like it's also worth mentioning that this can greatly help as the selection of signages increases with new additions, and more specific signage combinations crop up (eg. pairing fling signages together) where just pairing them with a generic arrow signage would be less helpful."