search

BEEmod / BEE2-items

Standard Items for the BEE2.4
132 stars 46 forks source link

Pedestal Guns must remain activated for a full 5 seconds before beginning to rotate. #4432

Open Aneonen opened 4 months ago

Aneonen commented 4 months ago

BEE2 Application Version

4.45.2

BEE2 Package Version

4.45

What operating system are you running on?

No response

Description of the bug

Currently, if the portal gun pedestal is activated manually via a puzzlemaker input, that input must remain active for at least 5 seconds before the gun actually starts to rotate and fire a portal.

This appears to occur because while the timer controlling the rotation fires every five seconds, it is not told to fire when it is enabled by the input. This means that pedestal buttons that last for less than 5 seconds, floor buttons that are only pressed briefly, etc., will not actually activate the item in practice, and in general the item becomes much more slow and clunky.

Expected behavior

The pedestal gun should start to rotate immediately after being activated.

Steps to reproduce

  1. Place down pedestal gun item
  2. Link an input into it that can remain active for more/less than 5 seconds.
  3. Observe that the pedestal does not appear to respond if the input remains active for less than 5 seconds, and then starts at the 5 second mark.

Logs and Reports

No response

Additional information

No response

TeamSpen210 commented 4 months ago

I should change the way the logic works so that it fires immediately when activated, then rotates to the next position afterwards.

vrad-exe commented 4 months ago

Maybe also add a mode where it doesn't rotate and just fires once when activated?