search

BEMADEV / Room-Management

1 stars 2 forks source link

Override Button #34

Closed marcierempel closed 9 months ago

marcierempel commented 9 months ago

Please go through all the tasks below

Please provide a brief description of the problem. Please do not forget to attach the relevant screenshots from your side.

After updating from the CentralAZ plugin to the Bema Room Management plugin, the override button is not visible to people in the Override Approval Group. The documentation indicates that 'Override: Always visible to the Override Approval Group, this button bypasses all approval processes and marks the reservation as Approved.' image

Here's a reservation that is showing PendingFinalApproval (there was no Final Approval Group set for this reservation type so it's expected that it is moved into an Approved State), but it doesn't, it stays in PendingFinalApproval and the WF shows as completed (without the booking ever being fully approved). I then tested that reservation with a Final Approval Group added, denied a room, which put it back into a Changes Needed state, then approved the room, putting it back into a PendingFinalApproval group state, but there is still no approval button or override button showing in that state. image image

In the history of this reservation, it shows that the Approval State Value changed from Pending Review to Overide: Approved but there was never any 'override' button selected.

Expected Behavior

Override button is available to approve any reservation by anyone in the Override Approval Group. If no Final Approval Group, reservation should be updated to an Approved state. If Final Approval Group is in place on reservation type, then people in that Final Approval Group should be able to Approve the booking (no Approval button or Override button is visable).

Actual Behavior

Override button is never visible. Approve button is not visible when trying to Approve in the PendingFinalApproval state.

Steps to Reproduce

Not able to test this in a different environment, it may only be a bug in our instance? We've had an issue in the past with the old version of the plugin where the Deny button did not show up and had to over ride that in the block, but I'm not sure if this is the same issue?

Rock Version

v15.3

Plugin Version

2.4.7.14

Client Culture Setting

en-US

tcavaletto commented 9 months ago

@marcierempel We've re-added the override button in an upcoming release. In the meantime, normal Final Approval Groups are unable to approve reservations with conflicts like the one in the screenshot above.

marcierempel commented 9 months ago

@tcavaletto Thank you for looking in to this! If I'm understanding you correctly, we are not able to approve any double bookings at all until the override function is corrected?

I'm not sure if it's related to the above, but I noticed that the workflow is supposed to set the reservation to Approved if there is no final approval group, but that is not happening when there is a conflict.

When can we anticipate the new release?

tcavaletto commented 9 months ago

@marcierempel We'll be releasing this tomorrow.

tcavaletto commented 9 months ago

@marcierempel The new release has some features that need further testing, so we'll be delaying it. In the meantime, applying these changes should fix your immediate issue: https://github.com/BEMADEV/Room-Management/commit/23358a734c1c6dee57180eb7a4cb3839375fa6ee

marcierempel commented 9 months ago

Hi Taylor – Thanks for the information on the changes. Any idea on the timeline for testing and implementing the update? That will help me determine if we can wait for it or not.

Marcie

From: Taylor Cavaletto @.> Date: Friday, February 23, 2024 at 9:27 AM To: BEMADEV/Room-Management @.> Cc: Marcie Rempel @.>, Mention @.> Subject: Re: [BEMADEV/Room-Management] Override Button (Issue #34)

@marcierempelhttps://github.com/marcierempel The new release has some features that need further testing, so we'll be delaying it. In the meantime, applying these changes should fix your immediate issue: 23358a7https://github.com/BEMADEV/Room-Management/commit/23358a734c1c6dee57180eb7a4cb3839375fa6ee

— Reply to this email directly, view it on GitHubhttps://github.com/BEMADEV/Room-Management/issues/34#issuecomment-1961629966, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKUFW2UMKAL3VULXOKLF6V3YVC7OTAVCNFSM6AAAAABDIX2RHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRRGYZDSOJWGY. You are receiving this because you were mentioned.Message ID: @.***>