BEMServer / bemserver-core

https://bemserver-docs.readthedocs.io/
MIT License
3 stars 3 forks source link

Energy cons TS x Site/Building: remove wh_conversion_factor #157

Closed lafrech closed 1 year ago

lafrech commented 1 year ago

This is now useless thanks to the unit conversion feature.

codecov[bot] commented 1 year ago

Codecov Report

Base: 94.82% // Head: 94.81% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (3c45b55) compared to base (68f056d). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #157 +/- ## ========================================== - Coverage 94.82% 94.81% -0.01% ========================================== Files 34 34 Lines 2298 2296 -2 Branches 437 438 +1 ========================================== - Hits 2179 2177 -2 Misses 95 95 Partials 24 24 ``` | [Impacted Files](https://codecov.io/gh/BEMServer/bemserver-core/pull/157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BEMServer) | Coverage Δ | | |---|---|---| | [bemserver\_core/model/energy.py](https://codecov.io/gh/BEMServer/bemserver-core/pull/157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BEMServer#diff-YmVtc2VydmVyX2NvcmUvbW9kZWwvZW5lcmd5LnB5) | `100.00% <ø> (ø)` | | | [bemserver\_core/process/energy\_consumption.py](https://codecov.io/gh/BEMServer/bemserver-core/pull/157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BEMServer#diff-YmVtc2VydmVyX2NvcmUvcHJvY2Vzcy9lbmVyZ3lfY29uc3VtcHRpb24ucHk=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BEMServer). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BEMServer)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.