internal/models: Refactor user models

BESTRobotics / registry

A national registry for information pertaining to BESTRobotics

0 stars 0 forks source link

internal/models: Refactor user models #31

Closed the-maldridge closed 5 years ago

the-maldridge commented 5 years ago

This includes the things we talked about in the 4/4 meeting.

Resolves #17 Resolves #28

m-wynn commented 5 years ago

From a technical perspective, User needs a UserProfile and []Students. It also breaks mail.

the-maldridge commented 5 years ago

Mail has been broken for some time, so I'm not worried about that. Once the models are approved additional work will be done on this branch to shim the types into other parts of the system. Does the User need the profile and students embedded or is it sufficient to provide APIs that can manipulate these fields?

m-wynn commented 5 years ago

I'm more concerned about failure to compile. Otherwise, APIs would be fine

the-maldridge commented 5 years ago

this was resolved somewhere in the merge of uber-branch monday.