17 review new users api and update vehicle api

BFARIAAL / api-pdc-backend

API PDC backedncode

1 stars 1 forks source link

17 review new users api and update vehicle api #24

Closed Charhmwang closed 10 months ago

Charhmwang commented 10 months ago

Implemented getAllVehicles & getVehicleById methods. Still in progress of updating other methods. Please ignore #23 PR request

Charhmwang commented 10 months ago

Really great job with this PR. You were able to successfully study the DSUsers api and implement a similar logic here. The comments left are mostly for code cleaning. Again, congratulations for the good work.

Thank you so much for this positive feedback! I'd add more features for Vehicle route and meanwhile starting resolve the new ticket I'm assigned. Will also bear in mind to keep the coding convention aligning to the User ones you provided :)