BG-Software-LLC / SSB-OneBlock

OneBlock Addon for SuperiorSkyblock2
GNU General Public License v3.0
17 stars 10 forks source link

Restarting the server isn't saving phases #7

Closed LuluxClient closed 2 years ago

LuluxClient commented 2 years ago

When you restart the server and the phase is changing it won't save your current phase and restart from phase 1. Also the placeholder is glitched. https://gyazo.com/a598c7fca66e2deb81905224fac2238b

OmerBenGera commented 2 years ago

You said the module doesnt work in your other issue... Now it works?

LuluxClient commented 2 years ago

You said the module doesnt work in your other issue...

Now it works?

No what I said is 0 commands are working but the game mode is working well kinda

LuluxClient commented 2 years ago

Hey any updates on that ?

OmerBenGera commented 2 years ago

Open a new issue for the hologram. About the data not saved, I get an error from SSB - do you get a similar one?

OmerBenGera commented 2 years ago

Check out latest version of SSB, let me know if it helps.

LuluxClient commented 2 years ago

Check out latest version of SSB, let me know if it helps.

Hey same issue on the latest version and 0 errors and I will create a new issue on git for the hologram

OmerBenGera commented 2 years ago

I tested it and it works fine for me. Check if the data was saved to the database file of OneBlock.

LuluxClient commented 2 years ago

I tested it and it works fine for me. Check if the data was saved to the database file of OneBlock.

It doesn't save the data in oneblock and I'm now getting this error: https://pastebin.com/5ciWKtxt

I'm going to try and reset everything and try again.

LuluxClient commented 2 years ago

Nop still not working and it's not saving.... I'll have to delete the whole SuperiorSkyblock folder

LuluxClient commented 2 years ago

Nop still not working and it's not saving.... I'll have to delete the whole SuperiorSkyblock folder

After deleting everything nothing is getting saved in the database.json of the oneblock addon I'm on 1.17.1 and on Java 17 I can provide a video if needed.

LuluxClient commented 2 years ago

Hey could you foward me your config to see if it's a config issue if it's fixed for you ?

OmerBenGera commented 2 years ago

Hey could you foward me your config to see if it's a config issue if it's fixed for you ?

I am using default files, besides that I fixed all the incorrect entity names for the version.

LuluxClient commented 2 years ago

Hey latest build seems fixed except for the hologram still being glitched

OmerBenGera commented 2 years ago

Hey latest build seems fixed except for the hologram still being glitched

Hmm weird. I will look into it again

OmerBenGera commented 2 years ago

I can't seem to replicate the issue with the holograms.

LuluxClient commented 2 years ago

I can't seem to replicate the issue with the holograms.

Tried on both latest SSB and Superior and now I can't even remove the bedrock block I'm getting this error when breaking the bedrock block: https://gyazo.com/5c3ec6aea0444113a3400f245d6d4004

and here is what I see after the bedrock is no longer here: https://gyazo.com/53892377c7bbeddeb8d0bad25d4796cd

OmerBenGera commented 2 years ago

I can't seem to replicate the issue with the holograms.

Tried on both latest SSB and Superior and now I can't even remove the bedrock block I'm getting this error when breaking the bedrock block: https://gyazo.com/5c3ec6aea0444113a3400f245d6d4004

and here is what I see after the bedrock is no longer here: https://gyazo.com/53892377c7bbeddeb8d0bad25d4796cd

I will look into it.

OmerBenGera commented 2 years ago

Does it still occur?

LuluxClient commented 2 years ago

I need to try but yes it was still I thing when I tried.

LuluxClient commented 2 years ago

Does it still occur?

Issue is fixed but when doing it you will restart your phase instead of going to the next one, players can abuse this and have unlimited phases (caused by the automatic restarts).

For example you're in phase 2 and you're going to be in phase 3. The countdown starts but the servers restarts. You join back and you see you're at the beginning of phase 2 instead of phase 3.

OmerBenGera commented 2 years ago

Check out latest build, lmk if it works now

OmerBenGera commented 2 years ago

Closing this for now If the issue still persists, lmk