search

BG-Software-LLC / SSB-OneBlock

OneBlock Addon for SuperiorSkyblock2
GNU General Public License v3.0
17 stars 10 forks source link

null placeholder when leader is offline #95

Closed m-surowiec closed 4 weeks ago

m-surowiec commented 1 month ago

Minecraft's Version

This server is running Paper version 1.21.1-100-master@20ec622 (2024-09-26T23:53:46Z) (Implementing API version 1.21.1-R0.1-SNAPSHOT)

Plugin's Version

2024.3-b341

Describe the bug

When the leader is offline and I execute /oneblock setphase mSuro_ 3 the phase doesn't update and if I try to send the {player} placeholder it returns null instead of the leader's name

To Reproduce

Parse the {player} placeholder when leader is offline

Additional Information

Screenshot 2024-10-19 at 15 49 01 null is the argument of a command executed with the placeholder

homerek111 commented 1 month ago

@OmerBenGera i confirm this issue

m-surowiec commented 1 month ago

I think it's because you are parsing the leader as Player instead of OfflinePlayer even though I don't think you use any method from the Player class

homerek111 commented 1 month ago

@OmerBenGera could you take a look at that?

OmerBenGera commented 4 weeks ago

Check out latest dev build, let me know if it is fixed

m-surowiec commented 4 weeks ago

It's fixed, thanks :)