search

BG-Software-LLC / SSB-SlimeWorldManager

An addon for SuperiorSkyblock2 that adds SlimeWorldManager support for worlds management!
18 stars 17 forks source link

Added support for AdvancedSlimePaper #17

Closed Happy-FZM closed 1 year ago

Happy-FZM commented 1 year ago

Added support for AdvancedSlimePaper

Should fix https://github.com/BG-Software-LLC/SSB-SlimeWorldManager/issues/14

OmerBenGera commented 1 year ago

You should merge into dev branch, not master.

Happy-FZM commented 1 year ago

ok

Happy-FZM commented 1 year ago

You implemented everything under the module AdvancedSlimeWorldManager. I think it should better be implemented in its own module - AdvancedSlimePaper. This way it will make the code more organized, and not have ugly package names (oldversion, newversion)

Done

OmerBenGera commented 1 year ago

There are errors with your gradle:

Execution failed for task ':AdvancedSlimePaper:compileJava'.
> Could not resolve all files for configuration ':AdvancedSlimePaper:compileClasspath'.
   > Could not resolve com.flowpowered:flow-nbt:2.0.2.
     Required by:
         project :AdvancedSlimePaper > com.infernalsuite.aswm:api:1.19.4-R0.1-SNAPSHOT:20230318.164317-1
      > Could not resolve com.flowpowered:flow-nbt:2.0.2.
         > Could not parse POM https://repo.rapture.pw/repository/maven-releases/com/flowpowered/flow-nbt/2.0.2/flow-nbt-2.0.2.pom
            > Could not find org.sonatype.oss:oss-parent:9.
              Searched in the following locations:
                - https://repo.bg-software.com/repository/nms/org/sonatype/oss/oss-parent/9/oss-parent-9.pom
                - https://repo.bg-software.com/repository/api/org/sonatype/oss/oss-parent/9/oss-parent-9.pom
                - https://repo.bg-software.com/repository/common/org/sonatype/oss/oss-parent/9/oss-parent-9.pom
                - https://repo.bg-software.com/repository/dependencies/org/sonatype/oss/oss-parent/9/oss-parent-9.pom
                - https://repo.infernalsuite.com/repository/maven-snapshots/org/sonatype/oss/oss-parent/9/oss-parent-9.pom
                - https://repo.rapture.pw/repository/maven-releases/org/sonatype/oss/oss-parent/9/oss-parent-9.pom
   > Could not find org.jetbrains:annotations:23.0.0.
     Searched in the following locations:
       - https://repo.bg-software.com/repository/nms/org/jetbrains/annotations/23.0.0/annotations-23.0.0.pom
       - https://repo.bg-software.com/repository/api/org/jetbrains/annotations/23.0.0/annotations-23.0.0.pom
       - https://repo.bg-software.com/repository/common/org/jetbrains/annotations/23.0.0/annotations-23.0.0.pom
       - https://repo.bg-software.com/repository/dependencies/org/jetbrains/annotations/23.0.0/annotations-23.0.0.pom
       - https://repo.infernalsuite.com/repository/maven-snapshots/org/jetbrains/annotations/23.0.0/annotations-23.0.0.pom
       - https://repo.rapture.pw/repository/maven-releases/org/jetbrains/annotations/23.0.0/annotations-23.0.0.pom
     Required by:
         project :AdvancedSlimePaper > com.infernalsuite.aswm:api:1.19.4-R0.1-SNAPSHOT:20230318.164317-1

Possible solution:
 - Declare repository providing the artifact, see the documentation at https://docs.gradle.org/current/userguide/declaring_repositories.html
Happy-FZM commented 1 year ago

There are errors with your gradle:

Execution failed for task ':AdvancedSlimePaper:compileJava'.
> Could not resolve all files for configuration ':AdvancedSlimePaper:compileClasspath'.
   > Could not resolve com.flowpowered:flow-nbt:2.0.2.
     Required by:
         project :AdvancedSlimePaper > com.infernalsuite.aswm:api:1.19.4-R0.1-SNAPSHOT:20230318.164317-1
      > Could not resolve com.flowpowered:flow-nbt:2.0.2.
         > Could not parse POM https://repo.rapture.pw/repository/maven-releases/com/flowpowered/flow-nbt/2.0.2/flow-nbt-2.0.2.pom
            > Could not find org.sonatype.oss:oss-parent:9.
              Searched in the following locations:
                - https://repo.bg-software.com/repository/nms/org/sonatype/oss/oss-parent/9/oss-parent-9.pom
                - https://repo.bg-software.com/repository/api/org/sonatype/oss/oss-parent/9/oss-parent-9.pom
                - https://repo.bg-software.com/repository/common/org/sonatype/oss/oss-parent/9/oss-parent-9.pom
                - https://repo.bg-software.com/repository/dependencies/org/sonatype/oss/oss-parent/9/oss-parent-9.pom
                - https://repo.infernalsuite.com/repository/maven-snapshots/org/sonatype/oss/oss-parent/9/oss-parent-9.pom
                - https://repo.rapture.pw/repository/maven-releases/org/sonatype/oss/oss-parent/9/oss-parent-9.pom
   > Could not find org.jetbrains:annotations:23.0.0.
     Searched in the following locations:
       - https://repo.bg-software.com/repository/nms/org/jetbrains/annotations/23.0.0/annotations-23.0.0.pom
       - https://repo.bg-software.com/repository/api/org/jetbrains/annotations/23.0.0/annotations-23.0.0.pom
       - https://repo.bg-software.com/repository/common/org/jetbrains/annotations/23.0.0/annotations-23.0.0.pom
       - https://repo.bg-software.com/repository/dependencies/org/jetbrains/annotations/23.0.0/annotations-23.0.0.pom
       - https://repo.infernalsuite.com/repository/maven-snapshots/org/jetbrains/annotations/23.0.0/annotations-23.0.0.pom
       - https://repo.rapture.pw/repository/maven-releases/org/jetbrains/annotations/23.0.0/annotations-23.0.0.pom
     Required by:
         project :AdvancedSlimePaper > com.infernalsuite.aswm:api:1.19.4-R0.1-SNAPSHOT:20230318.164317-1

Possible solution:
 - Declare repository providing the artifact, see the documentation at https://docs.gradle.org/current/userguide/declaring_repositories.html

It looks like your dependency has not been imported, but in my local testing it worked....

OmerBenGera commented 1 year ago

There are errors with your gradle:

Execution failed for task ':AdvancedSlimePaper:compileJava'.
> Could not resolve all files for configuration ':AdvancedSlimePaper:compileClasspath'.
   > Could not resolve com.flowpowered:flow-nbt:2.0.2.
     Required by:
         project :AdvancedSlimePaper > com.infernalsuite.aswm:api:1.19.4-R0.1-SNAPSHOT:20230318.164317-1
      > Could not resolve com.flowpowered:flow-nbt:2.0.2.
         > Could not parse POM https://repo.rapture.pw/repository/maven-releases/com/flowpowered/flow-nbt/2.0.2/flow-nbt-2.0.2.pom
            > Could not find org.sonatype.oss:oss-parent:9.
              Searched in the following locations:
                - https://repo.bg-software.com/repository/nms/org/sonatype/oss/oss-parent/9/oss-parent-9.pom
                - https://repo.bg-software.com/repository/api/org/sonatype/oss/oss-parent/9/oss-parent-9.pom
                - https://repo.bg-software.com/repository/common/org/sonatype/oss/oss-parent/9/oss-parent-9.pom
                - https://repo.bg-software.com/repository/dependencies/org/sonatype/oss/oss-parent/9/oss-parent-9.pom
                - https://repo.infernalsuite.com/repository/maven-snapshots/org/sonatype/oss/oss-parent/9/oss-parent-9.pom
                - https://repo.rapture.pw/repository/maven-releases/org/sonatype/oss/oss-parent/9/oss-parent-9.pom
   > Could not find org.jetbrains:annotations:23.0.0.
     Searched in the following locations:
       - https://repo.bg-software.com/repository/nms/org/jetbrains/annotations/23.0.0/annotations-23.0.0.pom
       - https://repo.bg-software.com/repository/api/org/jetbrains/annotations/23.0.0/annotations-23.0.0.pom
       - https://repo.bg-software.com/repository/common/org/jetbrains/annotations/23.0.0/annotations-23.0.0.pom
       - https://repo.bg-software.com/repository/dependencies/org/jetbrains/annotations/23.0.0/annotations-23.0.0.pom
       - https://repo.infernalsuite.com/repository/maven-snapshots/org/jetbrains/annotations/23.0.0/annotations-23.0.0.pom
       - https://repo.rapture.pw/repository/maven-releases/org/jetbrains/annotations/23.0.0/annotations-23.0.0.pom
     Required by:
         project :AdvancedSlimePaper > com.infernalsuite.aswm:api:1.19.4-R0.1-SNAPSHOT:20230318.164317-1

Possible solution:
 - Declare repository providing the artifact, see the documentation at https://docs.gradle.org/current/userguide/declaring_repositories.html

It looks like your dependency has not been imported, but in my local testing it worked....

It cannot find that dependency in any of the repositories. From where does com.flowpowered come from?

Happy-FZM commented 1 year ago

There are errors with your gradle:

Execution failed for task ':AdvancedSlimePaper:compileJava'.
> Could not resolve all files for configuration ':AdvancedSlimePaper:compileClasspath'.
   > Could not resolve com.flowpowered:flow-nbt:2.0.2.
     Required by:
         project :AdvancedSlimePaper > com.infernalsuite.aswm:api:1.19.4-R0.1-SNAPSHOT:20230318.164317-1
      > Could not resolve com.flowpowered:flow-nbt:2.0.2.
         > Could not parse POM https://repo.rapture.pw/repository/maven-releases/com/flowpowered/flow-nbt/2.0.2/flow-nbt-2.0.2.pom
            > Could not find org.sonatype.oss:oss-parent:9.
              Searched in the following locations:
                - https://repo.bg-software.com/repository/nms/org/sonatype/oss/oss-parent/9/oss-parent-9.pom
                - https://repo.bg-software.com/repository/api/org/sonatype/oss/oss-parent/9/oss-parent-9.pom
                - https://repo.bg-software.com/repository/common/org/sonatype/oss/oss-parent/9/oss-parent-9.pom
                - https://repo.bg-software.com/repository/dependencies/org/sonatype/oss/oss-parent/9/oss-parent-9.pom
                - https://repo.infernalsuite.com/repository/maven-snapshots/org/sonatype/oss/oss-parent/9/oss-parent-9.pom
                - https://repo.rapture.pw/repository/maven-releases/org/sonatype/oss/oss-parent/9/oss-parent-9.pom
   > Could not find org.jetbrains:annotations:23.0.0.
     Searched in the following locations:
       - https://repo.bg-software.com/repository/nms/org/jetbrains/annotations/23.0.0/annotations-23.0.0.pom
       - https://repo.bg-software.com/repository/api/org/jetbrains/annotations/23.0.0/annotations-23.0.0.pom
       - https://repo.bg-software.com/repository/common/org/jetbrains/annotations/23.0.0/annotations-23.0.0.pom
       - https://repo.bg-software.com/repository/dependencies/org/jetbrains/annotations/23.0.0/annotations-23.0.0.pom
       - https://repo.infernalsuite.com/repository/maven-snapshots/org/jetbrains/annotations/23.0.0/annotations-23.0.0.pom
       - https://repo.rapture.pw/repository/maven-releases/org/jetbrains/annotations/23.0.0/annotations-23.0.0.pom
     Required by:
         project :AdvancedSlimePaper > com.infernalsuite.aswm:api:1.19.4-R0.1-SNAPSHOT:20230318.164317-1

Possible solution:
 - Declare repository providing the artifact, see the documentation at https://docs.gradle.org/current/userguide/declaring_repositories.html

It looks like your dependency has not been imported, but in my local testing it worked....

It cannot find that dependency in any of the repositories. From where does com.flowpowered come from?

I'm pretty sure it's working perfectly fine on my PC.

https://repo.rapture.pw/service/rest/repository/browse/maven-releases/com/flowpowered/flow-nbt/

OmerBenGera commented 1 year ago

Amazing work, thanks for your contribution!