BG-Software-LLC / SSB-SlimeWorldManager

An addon for SuperiorSkyblock2 that adds SlimeWorldManager support for worlds management!
18 stars 17 forks source link

Fix WorldGuard protection issue #21

Closed tatteaid closed 9 months ago

tatteaid commented 1 year ago

Potentially fixes the WorldGuard protection issue, I only tested this for a minute or two, but one of the contributors of ASWM/ASP mentioned that called the WorldLoadEvent will make WorldGuard protection go away.

CrypticzXI commented 1 year ago

The current fix stated by tatteaid, is a valid fix and must be merged in order for full functionality with SWM and World Guard.

tatteaid commented 1 year ago

Yeah that's what I should've done, I forgot that you were using an interface adapter to support the different plugins so I thought that the #generateWorld method was SlimeWorld's method, not a method in the addon.

OmerBenGera commented 1 year ago

Yeah that's what I should've done, I forgot that you were using an interface adapter to support the different plugins so I thought that the #generateWorld method was SlimeWorld's method, not a method in the addon.

I see. I'd advice to make a separate method in SlimeUtils or something that calls generateWorld and afterwards the load event.

OmerBenGera commented 9 months ago

Implemented.