search

BG-Software-LLC / SuperiorSkyblock2

Optimized, feature packed Skyblock core.
https://bg-software.com/superiorskyblock/
GNU General Public License v3.0
168 stars 142 forks source link

Island Disband Causes Player to Drop into Void and not be able to use commands. #193

Closed Skizzles closed 3 years ago

Skizzles commented 3 years ago

Minecraft's Version 1.16.5 Yatopia/Paper

Plugin's Version: - SuperiorSkyblock-b107

As shown below on Yatopia the disband causes the player to fall into the void and not send the user to spawn. Production Environment Test: https://screenshots.skizzles.me/wAnA3/tAFUBIQi49.mp4

Dev Server Test:

(Yatopia - Build 42) https://screenshots.skizzles.me/wAnA3/wOZITisA15.mp4

(Paper- Build 573) https://screenshots.skizzles.me/wAnA3/COjasifI68.mp4

Some possibly related threads that I have seen: https://github.com/PaperMC/Paper/issues/4342 https://github.com/PaperMC/Paper/issues/3114 https://github.com/Spottedleaf/Tuinity/issues/78

Test with only SSB (b107) on Yatopia: https://screenshots.skizzles.me/wAnA3/TECoBipa74.mp4

Test with only SSB (b106) on Yatopia: https://screenshots.skizzles.me/wAnA3/xageDulo24.mp4

In conclusion: This occurs on B107 with Yatopia installed, versions before 107 do not have the issue with Yatopia. 107 does work with Paper but not Yatopia. Issue seems related to removing entities possibly ASync based off old issues with Paper/Tuinity.

OmerBenGera commented 3 years ago

I don't see how it's related to the entities removal, but I will check it out...

Skizzles commented 3 years ago

Looking into this further it seems to be upstream to Purpur and even upstream to Tuinity. Seems like an issue with Tuinity.

banicola commented 3 years ago

In fact, we use Tuinity and we have the same problem

Skizzles commented 3 years ago

@banicola what Tuinity build do you use?

banicola commented 3 years ago

I use the latest Build #218

Skizzles commented 3 years ago

Tested as far back in Tuinity as Build # 189 so this seems to be a weird bug in forks that occurs.

@OmerBenGera Not sure what you can do to resolve this issue but this is as much details as I could gather.

OmerBenGera commented 3 years ago

@Skizzles Does it happen with older dev builds of SSB as well (before the entities removal)?

OmerBenGera commented 3 years ago

Fixed in latest dev build, sorry about that ^^