search

BG-Software-LLC / SuperiorSkyblock2

Optimized, feature packed Skyblock core.
https://bg-software.com/superiorskyblock/
GNU General Public License v3.0
158 stars 135 forks source link

Vehicle limit message does not show #2006

Closed anhcraft closed 3 months ago

anhcraft commented 4 months ago

Minecraft's Version

git-Tuinity-91cefbf (MC: 1.16.5)

Plugin's Version

latest dev build

Describe the bug

When the vehicle limit reaches, the boat is removed, however, no message is shown to the player.

To Reproduce

  1. Place boats until it is impossible to place further
  2. No message is shown, even though the message exists in the locale file

Additional Information

https://github.com/BG-Software-LLC/SuperiorSkyblock2/blob/0b8f57c5018485060dcd09ea6282249c3d654f3d/src/main/java/com/bgsoftware/superiorskyblock/module/upgrades/type/UpgradeTypeEntityLimits.java#L193

OmerBenGera commented 4 months ago

Check out latest dev build, let me know if it is fixed

anhcraft commented 4 months ago

Check out latest dev build, let me know if it is fixed

Still not working

OmerBenGera commented 4 months ago

How do you put the minecart or boat? It seems to work fine for me.

anhcraft commented 4 months ago

How do you put the minecart or boat? It seems to work fine for me.

I made a fresh installation using the dev build. Configure the boat limit. Deop myself to prevent bypass permission. When putting the boat above the limit, no message is shown.

default-values:
  island-size: 20
  block-limits:
    HOPPER: 8
  entity-limits:
    MINECART: 4
    BOAT: 4
OmerBenGera commented 3 months ago

Maybe you're in creative? I disabled messages in creative mode (I don't know why, will change it)

anhcraft commented 3 months ago

Maybe you're in creative? I disabled messages in creative mode (I don't know why, will change it)

ah you are right, I was in creative. Tested again today and it works well (survival mode)

OmerBenGera commented 3 months ago

Awesome :) In latest dev build it should also work in creative mode