search

BG-Software-LLC / SuperiorSkyblock2

Optimized, feature packed Skyblock core.
https://bg-software.com/superiorskyblock/
GNU General Public License v3.0
168 stars 146 forks source link

New island not creating #2149

Open Envqu opened 3 months ago

Envqu commented 3 months ago

Minecraft's Version

1.20.4 Purpur 2176

Plugin's Version

B266

Describe the bug

Sometimes when new player want to create new island he has message that island is creating but it never happen. He have to disband island, wait 30/40 second and then create again but even then it could not work. Meanwhile other players doesnt has any problem with island creating. Its random for few players. For 250 players it happened maybe 15 times.

To Reproduce

New player creating new island

Additional Information

No response

Envqu commented 3 months ago

image This showing in console

*There is no island named null

OmerBenGera commented 3 months ago

Can you send me entire session logs that it happened in?

Envqu commented 3 months ago

I can but in private message

Envqu commented 3 months ago

Can you dm me on discord? Nickname: Envqu

OmerBenGera commented 3 months ago

I opened a ticket for you :)

OmerBenGera commented 3 months ago

I think the null message happens when you have a plugin / hook that executes an island command through the console or something Does it happen every time you create a new island?

Envqu commented 3 months ago

No. It happen few time a day but there is no rule. I think that its only occurs when island cant be created.

Example:

  1. New player joins the server.
  2. He types /is which opens gui to create island.
  3. He clicks create new island in gui and then there is like 70% chances of success and player will be teleported to new island or 30% chance of failure and there is message that island is being created but then its freezes and nothing happens for hours. Player has to disband island and then create again so process repeat.
OmerBenGera commented 3 months ago

Why would the console get a message about anything related to the island creation? This is 100% a command or something executed as console.

Envqu commented 3 months ago

Its GUI from SuperiorSkyBlock2 image https://pastebin.com/Sq6SqK9V image This message showing only when player cant create island and this bug happen

OmerBenGera commented 3 months ago

Does it happen with default config files?

Its GUI from SuperiorSkyBlock2 image https://pastebin.com/Sq6SqK9V image This message showing only when player cant create island and this bug happen

The screenshot of the event-commands does not matter. You might have another plugin or something interfacing with it, commands of missions or idk what. I suspect using default files it won't happen.

Envqu commented 3 months ago

I cant really check if its doesnt happen with default config because it not happening everytime. Maybe only like 1 in 10-20 times. I need a lot of players to check this and I cant really let them play with default config on production server. Its hard to track down but I've been using this config almost 2 years (without OneBlock addon) and it never happened.

Only plugin that can interfere into SuperiorSkyblock is KGenerators but it only checks flags and deleting generators on island disband. Problem is that island is not fully creating when this error occurs. I cant even teleport to this island with admin command /is admin tp nick. Player can only disband island and try to create new.

OmerBenGera commented 3 months ago

I added stack trace when SSB is sending messages to console, this should help us better understand when it occurs. Update to latest dev build, then run /is admin debug show_stacktrace and wait for the bug to occur. Once it occurs, you'll see in console stack traces (similar to an exception) - send me these stack traces via pastebin

Envqu commented 3 months ago

Okay, I know from where it comes. Its admin message sent when phase starting. Its executing when island is not fully created so thats why this null message occurs I guess. https://pastebin.com/5Xk1hbT3

At this moment I cant replicate bug with island not fully creating but I guess this error is not connected in any way with null message. Maybe latest version improve something? You can close this and if this bug will repeat I will just make another issue

OmerBenGera commented 3 months ago

Okay, I know from where it comes. Its admin message sent when phase starting. Its executing when island is not fully created so thats why this null message occurs I guess. https://pastebin.com/5Xk1hbT3

At this moment I cant replicate bug with island not fully creating but I guess this error is not connected in any way with null message. Maybe latest version improve something? You can close this and if this bug will repeat I will just make another issue

Is this the default config file of the one block module? If not, what command do you exeucte there?

Envqu commented 2 months ago

"islandunlockphase {player} 1", - its just custom command nothing to do with superiorskyblock "island admin msgall {player} &6 ", "island admin msgall {player} xyz", "island admin msgall {player} xyz", "island admin msgall {player} xyz", "island admin msgall {player} &6 ", "island admin titleall {player} 10 20 30 -title &6OneBlock 1 -subtitle &fPhase 1"

Envqu commented 2 months ago

And I replied here in closed issue in case if you haven't noticed. https://github.com/BG-Software-LLC/SuperiorSkyblock2/issues/2194#issuecomment-2268989312

OmerBenGera commented 2 months ago

"islandunlockphase {player} 1", - its just custom command nothing to do with superiorskyblock "island admin msgall {player} &6 ", "island admin msgall {player} xyz", "island admin msgall {player} xyz", "island admin msgall {player} xyz", "island admin msgall {player} &6 ", "island admin titleall {player} 10 20 30 -title &6OneBlock 1 -subtitle &fPhase 1"

I think I know what the issue is and why you get the null message, what I don't understand is why it only happens sometimes and not always. Can you send me your entire OneBlock folder? I want to test it out myself.

Envqu commented 2 months ago

It happened again today. I sent folder on Discord in ticket. Showtrace not showing anything when player is unable to teleport on bugged island or when I using is admin tp command. Unfortunatelly it was disabled when player created island.

OmerBenGera commented 2 months ago

Check out latest dev build of OneBlock, let me know if it still occurs

Envqu commented 1 month ago

Noone reported this so I will close this issue. If it will happen again I will open.

Envqu commented 3 weeks ago

Hi. It happened again. It looks like something blocking teleport to island. I have video of this issue: https://youtu.be/02X6tPPUPFU I fixed this island by teleporting 100 blocks next to it (Islands cords: -9600, 100, 1200, I teleported to -9500, 100, 1200 with /tp command and when chunks generated then teleport to island work.)

OmerBenGera commented 2 weeks ago

If something blocks the teleportation, then you should investigate it. You couldn't even teleport with Essentials /tp - I am not sure what I can do to fix it... Try switching to Paper maybe?

OmerBenGera commented 13 hours ago

Any news regarding this?