BG-Software-LLC / SuperiorSkyblock2

Optimized, feature packed Skyblock core.
https://bg-software.com/superiorskyblock/
GNU General Public License v3.0
166 stars 139 forks source link

Plains biome around the island #2152

Closed Wupin closed 1 month ago

Wupin commented 1 month ago

Minecraft's Version

This server is running Paper version 1.21-97-master@e71c1df (2024-07-19T11:57:42Z) (Implementing API version 1.21-R0.1-SNAPSHOT) You are running the latest version Previous version: 1.21-81-ceeb8c1 (MC: 1.21)

Plugin's Version

2024.1-b243

Describe the bug

After generating the island there is a ring of PLAINS biome even though I set worlds.normal.biome to WARM_OCEAN. it only happens after generating the island, nowhere else are these biomes in this world. I'm using this world-generator, but it should have no effect on this. image

To Reproduce

Generate island while having installed this World Generator and worlds.normal.biome: WARM_OCEAN

Additional Information

No response

OmerBenGera commented 1 month ago

Set your schematic's biome to warm_ocean as well, check if it fixes the issue

Wupin commented 1 month ago

It's not helping. The bug still occurs...

leon37921 commented 1 month ago

could be this problem

1978

OmerBenGera commented 1 month ago

Does it still happens if you use /is biome to change the biome?

Wupin commented 1 month ago

No it does NOT.

OmerBenGera commented 1 month ago

It might be related to #1978 I see you're a developer - try making a small plugin that justs prints the biome you stand in, and use it while standing in these chunks

Wupin commented 1 month ago

https://www.youtube.com/watch?v=ByKwTlMN04E

if you think it's client-side, it's not.

OmerBenGera commented 1 month ago

https://www.youtube.com/watch?v=ByKwTlMN04E

if you think it's client-side, it's not.

I will look into it, thanks

OmerBenGera commented 1 month ago

Use latest dev build, then try replicating the issue Check if you see warning in console. An example for such warning:

Setting biome WARM_OCEAN to non-existing chunk:
Wupin commented 1 month ago

yes, it spammed the console with [SuperiorSkyblock2] Setting biome WARM_OCEAN to non-existing chunk: ...........

OmerBenGera commented 1 month ago

yes, it spammed the console with [SuperiorSkyblock2] Setting biome WARM_OCEAN to non-existing chunk: ...........

And these were the chunks that are not plains, right?

Wupin commented 1 month ago

it printed like 670x times so i think it printed for all the biomes

OmerBenGera commented 1 month ago

Check out latest dev build, let me know if it is fixed

Wupin commented 1 month ago

I generated 10 islands and in 1 scenario no plains were generated. And noticed that if I pregenerate the chunks, no "Setting biome WARM_OCEAN to non-existing chunk" is printed but still theres plains biomes

Wupin commented 1 month ago

and in the pre-generated areas, if I create a island it will bugs and generate such weird corners also with PLAINS biomes

image

OmerBenGera commented 1 month ago

I don't know regarding the world-generation errors, but try latest dev build for the biomes.

Wupin commented 1 month ago

yes biomes are fixed!

OmerBenGera commented 1 month ago

yes biomes are fixed!

Awesome! I am closing this issue for now, if the issue with the generator still occurs, let me know by opening a new bug report.