search

BG-Software-LLC / SuperiorSkyblock2

Optimized, feature packed Skyblock core.
https://bg-software.com/superiorskyblock/
GNU General Public License v3.0
169 stars 147 forks source link

SkyBlock Placeholder Update Issue Report #2168

Closed leonm-cloud closed 2 months ago

leonm-cloud commented 4 months ago

Minecraft's Version

1.20.4

Plugin's Version

SuperiorSkyblock2-2024.1-b271.jar

Describe the bug

After departing from or dissolving an island, the %superior_island_location_exists% placeholder does not update to 'No' as expected. This failure causes the placeholder to remain unchanged, failing to refresh properly. Following a server restart, the placeholder correctly resets to 'No', indicating the absence of a superior island location. However, the issue arises specifically when leaving or dissolving an island, where the placeholder fails to reflect the updated state.

To Reproduce

When leaving, disbanding, or removing a member from an island, the placeholder value fails to update to 'No' and remains stuck on the previous role.

Additional Information

No response

OmerBenGera commented 4 months ago

If you run /papi parse me %superior_island_location_exists%, is it updated? I suspect its your scoreboard or something caching the value

leonm-cloud commented 4 months ago

I've attached a video to better show you what's happening.

http://i.lushmc.fun/u/NPCgzb.mp4

leonm-cloud commented 4 months ago

Update, it just says "Yes" for people who don't even have an island.

OmerBenGera commented 4 months ago

Update, it just says "Yes" for people who don't even have an island.

The placeholder returns "Yes" if players are standing inside an island, not if they are part of one. The spawn island is also considered an island, so when you're standing in the island, it will return "Yes"