BG-Software-LLC / SuperiorSkyblock2

Optimized, feature packed Skyblock core.
https://bg-software.com/superiorskyblock/
GNU General Public License v3.0
168 stars 146 forks source link

Generator.jar of Acidisland module not work with SSB2 ver 1.12.x #2192

Closed MynamisTG closed 13 hours ago

MynamisTG commented 3 months ago

Minecraft's Version

1.12

Plugin's Version

AcidIsand devbuild SSB2 devbuild

Describe the bug

Generator.jar Error With SSB2

To Reproduce

[17:53:35 INFO]: [SuperiorSkyblock2] GridManagerImpl::createIslandInternalAsync Tigerr_VN {0} {0} {nac} {true} {PLAINS} {normal} [17:53:35 ERROR]: [SuperiorSkyblock2] An unexpected error occurred while creating an island: [17:53:35 WARN]: at com.bgsoftware.superiorskyblock.nms.v1_12_R1.world.WorldEditSessionImpl.setBlock(WorldEditSessionImpl.java:94) [17:53:35 WARN]: at com.bgsoftware.superiorskyblock.world.schematic.impl.SuperiorSchematic.lambda$pasteSchematicAsyncInternal$2(SuperiorSchematic.java:151) [17:53:35 WARN]: at java.util.Collections$UnmodifiableCollection.forEach(Collections.java:1082) [17:53:35 WARN]: at java.util.Collections$UnmodifiableCollection.forEach(Collections.java:1082) [17:53:35 WARN]: at com.bgsoftware.superiorskyblock.world.schematic.impl.SuperiorSchematic.pasteSchematicAsyncInternal(SuperiorSchematic.java:145) [17:53:35 WARN]: at com.bgsoftware.superiorskyblock.world.schematic.impl.SuperiorSchematic.pasteSchematic(SuperiorSchematic.java:130) [17:53:35 WARN]: at com.bgsoftware.superiorskyblock.world.schematic.impl.SuperiorSchematic.lambda$pasteSchematic$0(SuperiorSchematic.java:121) [17:53:35 WARN]: at org.bukkit.craftbukkit.v1_12_R1.scheduler.CraftTask.run(CraftTask.java:64) [17:53:35 WARN]: at org.bukkit.craftbukkit.v1_12_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:52) [17:53:35 WARN]: at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) [17:53:35 WARN]: at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [17:53:35 WARN]: at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)

Additional Information

No response

OmerBenGera commented 3 months ago

Check out latest dev build, let me know if it is fixed

MynamisTG commented 3 months ago

Fixed, Thank you. But it still drops tps 1-10 and made crash when the player has finished creating the island and probably the process of generating water. Link video: https://drive.google.com/file/d/1H-aHysENKb__8hFVvCcJEE9edzIkHQEa/view?usp=sharing Log Crash: 10:46:06 ERROR: --- DO NOT REPORT THIS TO PAPER - THIS IS NOT A BUG OR A CRASH --- 10:46:06 ERROR: The server has not responded for 10 seconds! Creating thread dump

10:46:06 ERROR: Server thread dump (Look for plugins here before reporting to Paper!):

10:46:06 ERROR: Current Thread: Server thread 10:46:06 ERROR: PID: 29 | Suspended: false | Native: false | State: RUNNABLE

10:46:06 ERROR: com.bgsoftware.superiorskyblock.nms.v1_12_R1.NMSUtils$$Lambda$840/1029193025.accept(Unknown Source) 10:46:06 ERROR: java.lang.Iterable.forEach(Unknown Source)

10:46:06 ERROR: net.minecraft.server.v1_12_R1.PlayerConnectionUtils$$Lambda$647/167407512.run(Unknown Source) 10:46:06 ERROR: java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) 10:46:06 ERROR: java.util.concurrent.FutureTask.run(Unknown Source)

10:46:06 ERROR: java.lang.Thread.run(Unknown Source)

10:46:06 ERROR: --- DO NOT REPORT THIS TO PAPER - THIS IS NOT A BUG OR A CRASH ---

MynamisTG commented 3 months ago

Big Water chunk falling: https://gyazo.com/30e599101daee6ac48c67edadc6dd1bc

OmerBenGera commented 3 months ago

Check out latest dev build of SSB & AcidModule, let me know if it is better

OmerBenGera commented 13 hours ago

I am closing this as it seems to be fixed If the issue still occurs, let me know