BG-Software-LLC / SuperiorSkyblock2

Optimized, feature packed Skyblock core.
https://bg-software.com/superiorskyblock/
GNU General Public License v3.0
168 stars 146 forks source link

glow items in menu when selected are not working #2196

Open homerek111 opened 2 months ago

homerek111 commented 2 months ago

Minecraft's Version

This server is running AdvancedSlimePaper version 1.21-16202-HEAD@88f6d33 (2024-07-26T04:53:29Z) (Implementing API version 1.21-R0.1-SNAPSHOT

Plugin's Version

SuperiorSkyblock 2024.2-b297

Describe the bug

showing glow on items in menu does not work (for example on biomes/top)

on 1.21: obraz obraz

on 1.20.1: obraz obraz

To Reproduce

.

Additional Information

No response

OmerBenGera commented 2 months ago

I don't know about heads (which I think do not support glow enchantment), but I am using your exact same spigot jar, and I can see the items in the /is top menu glowing.

homerek111 commented 2 months ago

I don't know about heads (which I think do not support glow enchantment), but I am using your exact same spigot jar, and I can see the items in the /is top menu glowing.

@OmerBenGera I use all the latest versions and this weired situation happens

obraz

OmerBenGera commented 2 months ago

What version of your MC client do you use? I suspect it's related to ViaVersion or ViaBackwards and not the plugin

homerek111 commented 2 months ago

What version of your MC client do you use? I suspect it's related to ViaVersion or ViaBackwards and not the plugin

I tested it on 1.21 / 1.21.1 and 1.20.1 - its broken at all versions (as i noticed in my last message lore looks a little bit different on 1.21 and 1.20.1)

Srcsm commented 2 months ago

Do you happen to have internal shaders enabled? This used to cause this issue.

homerek111 commented 2 months ago

Do you happen to have internal shaders enabled? This used to cause this issue.

I do not - I have vanilla Minecraft

AlmostPanda commented 2 months ago

Hi, don't know if my issue is related to this, but if I click on an item in /is top to sort the item I click on gets an empty line in lore screenshot: image

its not a big problem but it may confuse some people if you have an item with lore: image

this is the item in top-islands.yml '&': type: PLAYER_HEAD sorting-type: 'PLAYERS' name: '&6Seřadit podle aktuálního' lore:

PS: using version 2024.2-b300 Paper version 1.21-130-master@b1b5d4c (2024-08-10T10:02:42Z) (Implementing API version 1.21-R0.1-SNAPSHOT)

Srcsm commented 2 months ago

Do you happen to have internal shaders enabled? This used to cause this issue.

I do not - I have vanilla Minecraft

Your glint settings (specifically Glint Speed) are above 0% in your video settings? It says they affect item glow, and setting Glint Speed to 0 on vanilla, with a vanilla client and SSB, is the only way I can replicate this.

homerek111 commented 2 months ago

Do you happen to have internal shaders enabled? This used to cause this issue.

I do not - I have vanilla Minecraft

Your glint settings (specifically Glint Speed) are above 0% in your video settings? It says they affect item glow, and setting Glint Speed to 0 on vanilla, with a vanilla client and SSB, is the only way I can replicate this.

nope. my glint speed is 50% and items in my superiorskyblock gui don't have glow effect at all + this empty line in lore comes (when it should be glowed)

OmerBenGera commented 2 months ago

Do you happen to have internal shaders enabled? This used to cause this issue.

I do not - I have vanilla Minecraft

Your glint settings (specifically Glint Speed) are above 0% in your video settings? It says they affect item glow, and setting Glint Speed to 0 on vanilla, with a vanilla client and SSB, is the only way I can replicate this.

nope. my glint speed is 50% and items in my superiorskyblock gui don't have glow effect at all + this empty line in lore comes (when it should be glowed)

This empty line means SSB added the enchantment to the item

AlmostPanda commented 2 months ago

I do not - I have vanilla Minecraft

do you use classic minecraft launcher or any mods like optifine and so on? also found out that setting graphic to fancy/fast or brightness can cause it

homerek111 commented 2 months ago

I do not - I have vanilla Minecraft

do you use classic minecraft launcher or any mods like optifine and so on? also found out that setting graphic to fancy/fast or brightness can cause it

100% vanilla - classic launcher + 0 mods

I tested it from different accounts / even from another PC and this glow in superior gui just do not work every time.

OmerBenGera commented 13 hours ago

Any news regarding this?

homerek111 commented 12 hours ago

Any news regarding this?

nothing changed - still not glowing