search

BG-Software-LLC / SuperiorSkyblock2

Optimized, feature packed Skyblock core.
https://bg-software.com/superiorskyblock/
GNU General Public License v3.0
167 stars 142 forks source link

FarmingMission barely registering growing pumpkins/melons or anything #2215

Closed Pinchuini481 closed 1 month ago

Pinchuini481 commented 1 month ago

Minecraft's Version

1.20.4

Plugin's Version

2024.2

Describe the bug

the mission only recognises like 1 in 10 pumpkin grows, so let's say i grow 10 pumpkins. it will say i grew one. i planted them myself and i can't seem to find why doesn't recognize it most of the time.

To Reproduce

just install the plugin and try to do the mission, i think all of them barely work

Additional Information

image

Pinchuini481 commented 1 month ago

after testing a lot i have a little more info, if i plant it and stay online, i SSB does notice it and just gives me +1 for pumpkin or whatever. however if i go offline and come back online later. it's like the game completely forgot that i planted the crops. so even if it grows when i'm alone. it doesn't get added to my missions

Pinchuini481 commented 1 month ago

image my plugins

Pinchuini481 commented 1 month ago

latest dev build fixed it, sorry

Srcsm commented 1 month ago

I just want to add that I was able to replicate this, even though they mention it resolved for them.

Here are my count before a restart. I've let some crops grow before restarting, but I haven't harvested them yet: image

Here's after restarting, and harvesting the crops I had let grow, as well harvesting multiple in-game days worth of regrowth: image None if it counted towards my counts. The melons being 1 off is because I had accidentally broke the main plant of a melon, so replanted it since the restart and used bone meal on it and it grew a melon right away.

After removing all the main pumpkin and melon plants, replanting them all, letting them grow and then harvesting them, my counts increase: image

Paper 1.20.4-497 and SuperiorSkyblock2 v2024.2-b311

AlmostPanda commented 1 month ago

I just want to add that I was able to replicate this, even though they mention it resolved for them.

Here are my count before a restart. I've let some crops grow before restarting, but I haven't harvested them yet:

Here's after restarting, and harvesting the crops I had let grow, as well harvesting multiple in-game days worth of regrowth: None if it counted towards my counts. The melons being 1 off is because I had accidentally broke the main plant of a melon, so replanted it since the restart and used bone meal on it and it grew a melon right away.

After removing all the main pumpkin and melon plants, replanting them all, letting them grow and then harvesting them, my counts increase:

Paper 1.20.4-497 and SuperiorSkyblock2 v2024.2-b311

same thing happens for me, but also with cactus/sugar cane if I plant it and restart server then when it grow up it doesnt count but if I replant it, it counts it also works on crops like wheat, beetroots and other, just plant it and restart server, when it grows up it doesnt count

using Paper 1.21-130 (last build) and SuperiorSkyblock2 v2024.2-b311

BUT after deleting whole datastore folder, and starting server, it seems to work again without any issue, so maybe some problem with saving data to database? dont know

AlmostPanda commented 4 weeks ago

@OmerBenGera can you take a look at it when you will be free, please

OmerBenGera commented 4 weeks ago

@OmerBenGera can you take a look at it when you will be free, please

Open a new issue regarding this. You said it works for you on clean setup, so it's probably something related to your specific setup.

AlmostPanda commented 4 weeks ago

Open a new issue regarding this. You said it works for you on clean setup, so it's probably something related to your specific setup.

yeah it works on clean setup, then I add the plugin on live server and it didnt work so I made a copy of live server database and moved it on my local test server and it still didnt work, then I left it behind for around 2 weeks, meanwhile I made a 1.21 update on my another test server....

I think I forgot to replant crops when you made the fix for FarmingMission and thats why it didnt work, because now I jumped on our live 1.20.4 server where it didnt count, replanted made a restart and not it counts so Im just dumb and its probably really fixed on my side.

sorry about that

edit: just tried on live server (1.20.4+ASP), replanting crops works