BG-Software-LLC / SuperiorSkyblock2

Optimized, feature packed Skyblock core.
https://bg-software.com/superiorskyblock/
GNU General Public License v3.0
168 stars 146 forks source link

items can be removed from containers outside of the island-border #2220

Closed leon37921 closed 1 month ago

leon37921 commented 2 months ago

Minecraft's Version

This server is running Paper version git-Paper-435 (MC: 1.20.4) (Implementing API version 1.20.4-R0.1-SNAPSHOT) (Git: 681bbff)

Plugin's Version

SuperiorSkyblock2 version 2024.2-b315

Describe the bug

Players can remove items from chests, barrels, furnaces (can interact with containers) that are placed outsite the island-border.

To Reproduce

  1. create island
  2. toggle island-border off and go outside
  3. open container e.g. barrel and remove items

Additional Information

The schematic is bigger than the border-size at the beginning. You can expand the border to unlock new islands with chests and barrels on them.

This also applies to deleted islands if there are still barrels outside, because when an island is deleted only the area within the border is deleted.

https://github.com/user-attachments/assets/b0bd8367-fc4f-4e9f-baa8-226e385fce5f

OmerBenGera commented 2 months ago

Can they interact with them on other islands as well?

leon37921 commented 2 months ago

Can they interact with them on other islands as well?

The player can interact with containers outsite of his own island The player can't interact with containers outsite of other players islands The player can interact with containers outsite of deleted islands (the outer parts of the island-schematic doesn't get deletet when entering the command /is delete. Only the parts inside the border.

edit: I found another bug while testing #2223

OmerBenGera commented 2 months ago

You didnt answer my question. Are you able to interact with containers inside other islands?

leon37921 commented 2 months ago

You didnt answer my question. Are you able to interact with containers inside other islands?

No, containers inside other islands are protected

OmerBenGera commented 1 month ago

Check out latest dev build, let me know if it is fixed

leon37921 commented 1 month ago

fixed. Perfect. Thank you!