BG-Software-LLC / SuperiorSkyblock2

Optimized, feature packed Skyblock core.
https://bg-software.com/superiorskyblock/
GNU General Public License v3.0
168 stars 142 forks source link

Island Worth/Counts Duplicating on restarts #386

Closed MythricHD closed 3 years ago

MythricHD commented 3 years ago

Minecraft's Version

Paper 1.12.2

Plugin's Version

b199

Describe the bug

We've had this issue on and off for a few updates now where on restarts the spawner count and thus island worth gets duplicated on restart. I tested with the latest build of ss2 and ws but the issue is persistent.

Image of issue: https://i.riftmc.co/xwRsg5btqS.png (as you can see there is only one spawner placed)

Doing /is admin recalc refreshes the count and corrects it but a restart will mess it up again

To Reproduce

Config attached, You can take a look in the worth file to see how I have it set up but essentially just place down a spawner, restart the server and check your /is counts menu

archive-2021-07-20T153449-0400.tar.gz

Additional Information

No response

OmerBenGera commented 3 years ago

I can't seem to replicate the issue, might be something with your worth file. Mind uploading it to pastebin (I know you attached a zip file, I prefer to have it on pastebin)

MythricHD commented 3 years ago

https://bin.bloom.host/isawejexeg

OmerBenGera commented 3 years ago

it looks fine - do you have a limit or something for "MOB_SPAWNER" as a global block?

MythricHD commented 3 years ago

Nope its worked before and i have never touched the file, it just stopped working within the last b196-199 updates that I noticed

OmerBenGera commented 3 years ago

Nope its worked before and i have never touched the file, it just stopped working within the last b196-199 updates that I noticed

I will look into that as soon as possible.

WarnDa commented 3 years ago

I have the same issue since some month, but I don't know how to replicate the issue.

My player get for example 100 spawners, it counts as 200-250 spawners, using wildstacker as spawner provider on paper 1.12

(only happening with spawners)

OmerBenGera commented 3 years ago

I can't seem to replicate the issue, mind sharing with me your files of SSB?

DebuffPvP commented 3 years ago

yo the dude with the issue are you using shopguiplus by any chance for the worth of the spawners or doing it directly through superiorskyblock?

MythricHD commented 3 years ago

I do use shopgui for players to obtain spawners

OmerBenGera commented 3 years ago

I do use shopgui for players to obtain spawners

We suspect that the issue is caused by integration with SSB and SGP. The fact that you have it installed only increases the chance that the issue is due to that, and I am gonna check that out asap.

OmerBenGera commented 3 years ago

Check out latest dev build, should be fixed.

MythricHD commented 3 years ago

Seems like its fixed, /is admin recalc seems to be broken in b295 but I can open a new ticket for that if desired

OmerBenGera commented 3 years ago

Seems like its fixed, /is admin recalc seems to be broken in b295 but I can open a new ticket for that if desired

Please do so