BG-Software-LLC / WildChests

Sell chests, auto crafters, storage units, larger chests and more in one plugin!
https://bg-software.com/wildchests/
GNU General Public License v3.0
34 stars 23 forks source link

ShopGUIPlus hook #156

Closed lilspojo closed 1 year ago

lilspojo commented 1 year ago

Minecraft's Version

1.19.3 git-Purpur-1876

Plugin's Version

2022.7-b87 & 2022.7-b88

Describe the bug

The hook into ShopGUIPlus doesnt work since dev build 2022.7-b87, while 2022.7-b86 works perfectly fine. The exact issue is it defaults to the WildChests set item values when set to ShopGUIPlus.

To Reproduce

  1. Use dev build 2022.7-b87 or 2022.7-b88
  2. Use the prices-provider ShopGUIPlus
  3. Test in-game, it will default to the sell values set in the config.

Additional Information

No response

OmerBenGera commented 1 year ago

Do you see "Using ShopGUIPlus as PricesProvider" in console? Use CTRL+F in your logs file

lilspojo commented 1 year ago

Doing that, i find this as a result on b88: [13:43:55] [Server thread/INFO]: [WildChests] - Couldn't default prices provider.

OmerBenGera commented 1 year ago

Couldn't default prices provider

You have your prices provider configured as WildChests. This can be if you configured it to be WildChests or you mistyped the prices provider

lilspojo commented 1 year ago

Thing is, it’s set to ShopGUIPlus in the config, and switching back to b86 works flawlessly, so it’s set properly

OmerBenGera commented 1 year ago

Thing is, it’s set to ShopGUIPlus in the config, and switching back to b86 works flawlessly, so it’s set properly

Upload your config file to pastebin and send it here

lilspojo commented 1 year ago

Here’s the pastebin link: https://pastebin.com/HcrKv27x

OmerBenGera commented 1 year ago

No clue why it occurs, it works fine for me Are you sure you have SGP installed and works?

lilspojo commented 1 year ago

I do have ShopGUIPlus installed and it does work, reverting to b86 fixed it so it’s clear that ShopGUIPlus itself is fine

OmerBenGera commented 1 year ago

Try it on a server with only WildChests and SGP on latest dev build of WC, let me know if it still occurs

OmerBenGera commented 1 year ago

Any news regarding this?

lilspojo commented 1 year ago

Sorry I forgot about this, and no I don’t have any updates, I am no longer using the plugin, and am using one that better suits my needs.