BG-Software-LLC / WildChests

Sell chests, auto crafters, storage units, larger chests and more in one plugin!
https://bg-software.com/wildchests/
GNU General Public License v3.0
39 stars 23 forks source link

Server Crashes on Joining #211

Closed DuneSciFye closed 11 months ago

DuneSciFye commented 1 year ago

Minecraft's Version

This server is running SlimeWorldManager version git-SlimeWorldManager-15186 (MC: 1.20.1) (Implementing API version 1.20-R0.1-SNAPSHOT) (Git: 082d551 on paper_upstream)

Plugin's Version

WildChests version 2023.3

Describe the bug

When some players join, the server crashes basically every time. If they join back right after the server starts back up after the crash, it works fine.

To Reproduce

NA

Additional Information

https://pastebin.com/gNc8Qm6U

OmerBenGera commented 1 year ago

Report it over SlimeWorldManager's authors. WildChests tries to read data from the chunk in ChunkLoadEvent and this causes the server to crash. It works fine on Spigot & Paper, therefore it is not related to WildChests directly.

DuneSciFye commented 1 year ago

Could you add a delay to the chests loading?

DuneSciFye commented 1 year ago

Could you add the delay made by this fork: https://github.com/WaterArchery/WildChests

OmerBenGera commented 1 year ago

That developer does not check if the chunk is still loaded, which can cause the chunk to load again.

DuneSciFye commented 1 year ago

Well is there any way of delaying it to make it work with SWM?

DuneSciFye commented 1 year ago

I'm willing to pay for some sort of configuration or anything.

DuneSciFye commented 11 months ago

This is still happening: https://pastebin.com/Qx6BE8fa Please help

DuneSciFye commented 11 months ago

image

https://github.com/BG-Software-LLC/WildChests/blob/713e2c636b95d49c85712e14e812f23b711bbcc6/src/main/java/com/bgsoftware/wildchests/listeners/ChunksListener.java#L35

OmerBenGera commented 11 months ago

As I said, you should report it over SlimeWorldManager 's authors. Fixing it on WC's end will still cause issues with other plugins if they do the same. Bugs should be fixed from the root cause of the issue, and not as hot-patches by the plugin developers.

DuneSciFye commented 11 months ago

They have been able to fix it!