search

BG-Software-LLC / WildStacker

Stacked drops, stacked entities, stacked blocks and stacked spawners in one plugin!
https://bg-software.com/wildstacker/
GNU General Public License v3.0
89 stars 36 forks source link

Memory leak #892

Open Xayanix opened 5 months ago

Xayanix commented 5 months ago

Minecraft's Version

1.20

Plugin's Version

2023.3

Describe the bug

image

To Reproduce

Server dies after few hours cause of OOM

Additional Information

No response

OmerBenGera commented 5 months ago

What version of spigot do you use? Give me the exact output of /version

Xayanix commented 5 months ago

2023.3-b36

Xayanix commented 5 months ago

image

Xayanix commented 5 months ago

It's full of SpawnCause.SPAWNER

Xayanix commented 5 months ago

When mob spawner spawns entity, and u remove it via entity.remove() then it stays in ur cache causing memory leak

SrMonsterYT commented 3 months ago

when I updated wildstacker, I also noticed an increase in memory, I haven't figured out the cause yet, but wildstacker was one of the plugins I updated recently

plugin: WildStacker-2023.3-b42.jar server: version git-Pufferfish-47 (MC: 1.20.4)

OmerBenGera commented 3 months ago

Check out latest dev build, let me know if it is better

SrMonsterYT commented 3 months ago

Check out latest dev build, let me know if it is better

for me it seems to have increased the leakage even more

SrMonsterYT commented 3 months ago

@OmerBenGera

there is still memory leakage

spark: https://spark.lucko.me/ulh2wRYUeg

spark heapsummary: https://spark.lucko.me/gla6pQD7In

version plugin: WildStacker-2023.3-b45.jar

SrMonsterYT commented 3 months ago

@OmerBenGera

there is still memory leakage

spark: https://spark.lucko.me/ulh2wRYUeg

spark heapsummary: https://spark.lucko.me/gla6pQD7In

version plugin: WildStacker-2023.3-b45.jar

@OmerBenGera I've added more information above, what do you recommend I go back to version 35 and wait for you to correct it?

SrMonsterYT commented 3 months ago

@OmerBenGera help pls

OmerBenGera commented 3 months ago

@OmerBenGera there is still memory leakage spark: https://spark.lucko.me/ulh2wRYUeg spark heapsummary: https://spark.lucko.me/gla6pQD7In version plugin: WildStacker-2023.3-b45.jar

@OmerBenGera I've added more information above, what do you recommend I go back to version 35 and wait for you to correct it?

Your spark heap does not show anything related to WildStacker. Try using dumpheap, and send me the output file so I can inspect it.

@Xayanix Have you looked at the latest dev build? Is it better now?

Xayanix commented 3 months ago

@OmerBenGera there is still memory leakage spark: https://spark.lucko.me/ulh2wRYUeg spark heapsummary: https://spark.lucko.me/gla6pQD7In version plugin: WildStacker-2023.3-b45.jar

@OmerBenGera I've added more information above, what do you recommend I go back to version 35 and wait for you to correct it?

Your spark heap does not show anything related to WildStacker. Try using dumpheap, and send me the output file so I can inspect it.

@Xayanix Have you looked at the latest dev build? Is it better now?

I didnt check it, fixed it on my own. I told u where leak was

SrMonsterYT commented 3 months ago

@OmerBenGera there is still memory leakage spark: https://spark.lucko.me/ulh2wRYUeg spark heapsummary: https://spark.lucko.me/gla6pQD7In version plugin: WildStacker-2023.3-b45.jar

@OmerBenGera I've added more information above, what do you recommend I go back to version 35 and wait for you to correct it?

Your spark heap does not show anything related to WildStacker. Try using dumpheap, and send me the output file so I can inspect it. @Xayanix Have you looked at the latest dev build? Is it better now?

I didnt check it, fixed it on my own. I told u where leak was

add in Pull requests please, help both him and me, if you can of course, we would be very grateful