BGforgeNet / FO2tweaks

Fallout 2 tweaks
https://forums.bgforge.net/viewforum.php?f=26
125 stars 11 forks source link

fo2tweaks.ini: damage_mod_ammo_dr. Some ammunition repeats here that is already in default list #82

Closed tnevolin closed 2 years ago

tnevolin commented 2 years ago

Suggestion.

You have default ammunition list here. At the same time some ammunition from this list repeat in fo2tweaks.ini, damage_mod_ammo_dr section:

[damage_mod_ammo_dr]
; map ammo PID to ammo DR. Already includes all vanilla and EcCo ammo.
; See PIDs here https://github.com/BGforgeNet/Fallout2_Restoration_Project/blob/master/scripts_src/headers/itempid.h#L181
; optional changes: consistency - make all JHP ammo have DR mod of +35%, AP -35%, FMJ -20%:
; 10mm JHP
29=35
; 10mm AP
30=-35
; .44 Magnum JHP
31=35
; 7.62mm (presumed to be FMJ)
363=-20

I believe it would be better to transfer these "optional" changes into default list, since both of them are introduced by you. It is not some mod merging remnant or something. Otherwise, it makes a confusing feeling that these optional changes are some sort of update for some other mod or something.

burner1024 commented 2 years ago

The list is kept short intentionally, just to show how it works. The config is already quite long and hard to navigate. I'm not particularly against keeping the changes here or there, just not sure if that will confuse more people than help.

tnevolin commented 2 years ago

I meant to move it other way around: from the config into the code default values. That would make config shorter. You can certainly leave some examples there and comment them out just to show people what they can use.