search

BGforgeNet / FO2tweaks

Fallout 2 tweaks
https://forums.bgforge.net/viewforum.php?f=26
115 stars 10 forks source link

"Healing revision" compatibility with other "HOOK_USESKILL" global scripts. #91

Closed dekrus closed 2 years ago

dekrus commented 2 years ago

There is problem, if "Healing revision" is enabled, then any other script using hook_useskill will not work unless it loads after or register_hook_proc_spec is specified.

This is because your "gl_g_healing_revision.ssl" script has a moment when the original engine handler is returned in the HOOK_USESKILL. (if mod is enabled and used any non FA or DOC skill) https://github.com/BGforgeNet/FO2tweaks/blob/1ea03bd878525c64f0731d2581a4803ce0994865/source/gl_g_healing_revision.ssl#L281-L283

These lines do not affect the work of your script in any way and can be removed.

burner1024 commented 2 years ago

did you test that change?

dekrus commented 2 years ago

Yes, I played 3 hours in F:Nevada, tested different skills on different critters. During rest, after loading the game, after uninstalling the mod, etc. Everything including first aid and doctor skill works flawlessly.

burner1024 commented 2 years ago

Cool, thanks.