Cannot translate pipboy.msg ?

[Okahye]

I'm currently playtesting the french RPU and I cannot find the lines of pipboy.msg anywhere. Especially the "rest for 10 minutes", "rest until healed", "you cannot rest here" etc... Result : the pipboy is not translated in french RPU, is there a specific reason why ?

Thanks,

[burner1024]

Yes... it's excluded from translation system. The reason is the way it's structured. Specifically, holodisk info and stuff. There are multiple paragraphs, but they are split into lines, and there's limit on line length to be displayed properly. It's too hard to translate it sanely using string model, because here strings do no represent logical translation units.

Bottom line is, feel free to translate it manually ("the olden way") and submit a pull request.

[Okahye]

Ok thanks for your answer, I got the last translation file here, but I don't know how to upload it exactly, because you integrate everything in one big french.dat file, right ? Should I do a pull request for one separated file ?

[burner1024]

Yes, just make a pull request. It will be packaged automatically into the next release. But make sure it's well-formed, has the exact same number of strings and that they are not too long (otherwise they will be dangling from pip-boy display.)

[Okahye]

Do you want me to create a new branch or should I commit directly into dev or master ?

[burner1024]

Usually using a separate branch for a pull request is preferred, but it's really a question of how you want to maintain your own fork. Dev is far behind, though.

[Okahye]

done ;) Thank you