BGforgeNet / Fallout2_Restoration_Project

Fallout 2 Restoration Project, updated
https://forums.bgforge.net/viewforum.php?f=39
583 stars 38 forks source link

Enhancement: Doctors healing NPCs and crippled limbs #168

Closed MarbledModulator closed 1 year ago

MarbledModulator commented 1 year ago

I was looking through some of the closed issues to see what enhancements you considered in-scope or out-of-scope and was interested by closed issue 39

You expressed possible interest in incorporating that change but closed the issue due to a lack of response.

I think it could be RP material, but I'll need the full list of doctors with names and their behaviour and corresponding saves for all of them to make a decision and maybe implement it.

Per the request you made in closed issue 39, I created a table that Iists all of the doctors and their services https://fallout.fandom.com/wiki/Fallout_2_doctors#Locations_and_services

The only thing that differs between the Restoration patch and that table is that killap added restocking stores to Doc Johnson and Doc Jubilee.

I thought we could discuss my proposed changes before I get the "corresponding saves" you requested. It's been two years since closed issue 39 and I wanted to check that you haven't changed your mind about this whole idea. I'll talk more about this at the end of my post but I'm happy to write the code if you agree with my proposed changes but don't want to do the work.

Add "Heal NPCs" functionality to 5 doctors I don't really see any reason why the following doctors couldn't or wouldn't want to heal NPCs. It seems random that these doctors don't heal NPCs but others do. My guess is these level creators ran out of time or didn't realize other levels' creators decided to have their doctors heal NPCs.

Add "Fix crippled limbs" functionality to 2 doctors It seems random that the following doctors don't fix crippled limbs when less qualified facilities can fix crippled limbs. Though some characters reference why they can't fix crippled limbs in their .MSG's (Doc Jones says "I'm sorry, but I don't have the proper facilities to perform surgery" and Joseph says "I'm sorry, but I'm not a medical doctor and I can't perform surgery" for example), Doc Johnson's dialogue and Doc Jubilee's dialogue don't mention anything about crippled limbs.

Add "Remove radiation and poison" functionality to 1 doctor

I recognize I am proposing enhancements so its understandable if you think some or all of these are out of scope of the Restoration Project.

If you agree with the changes but dont' want to write the code, I can take a crack at creating the code if you would prefer. I've never actually made a Fallout 2 mod before but I'm very familiar with Fallout 2's .SSL files and .MSG files. I'll be able to write all the code but I am sure I will have questions and the final product will most likely have some mistakes. Not sure if that would just be more work for you than you just doing yourself.

Let me know what you think the above proposed changes.

burner1024 commented 1 year ago

From strict PoV, the only restoration would be Dr. Fung. Altogether, it's a minor convenience feature that doesn't make much difference. I'm not too interested in working on that, but if you want to send a pull, that's possible. It's a pain to maintain different scripts for upu and rpu, so I suggest that you make minimal changes and gate the entire feature behind an ini setting.

MarbledModulator commented 1 year ago

Sure, will do. I'll start work on it this weekend.

MarbledModulator commented 1 year ago

Burner, I don't think I'll be able to get to work on this anytime soon. I switched to Linux a while ago and haven't been able to get Fallout working on it yet. Maybe we should close this issue for now and can reopen it whenever I get everything working and the script updated?

burner1024 commented 1 year ago

As you wish.