BGforgeNet / Fallout2_Restoration_Project

Fallout 2 Restoration Project, updated
https://forums.bgforge.net/viewforum.php?f=39
583 stars 38 forks source link

dcaddict: error: attemmpting to use move_to in during loading #202

Closed phobos2077 closed 7 months ago

phobos2077 commented 1 year ago

What happened

See this error spamming debug log during save load: dcaddict: error: attemmpting to use move_to in during loading

Probably need to add check for loading.

NovaRain commented 1 year ago

The error log actually comes from "a check for loading": https://github.com/BGforgeNet/Fallout2_Restoration_Project/blob/master/scripts_src/headers/den.h#L1100 CHECK_LEVEL gets called in map_enter_p_proc for various NPCs in the Den and V15.

burner1024 commented 7 months ago

Not sure. Is there any point in having this check/log? Do the corresponding scripts need to be fixed somehow? Or move_to resolves at a later point?

NovaRain commented 7 months ago

Not sure. Is there any point in having this check/log? Do the corresponding scripts need to be fixed somehow? Or move_to resolves at a later point?

I don't think the log is needed, in the original RP 2.3.3 script source there's no logging in CHECK_LEVEL macro. From the current macro, might just collapse the IF condition if the intention was to prevent move_to call during loading, or simply remove the log line.