BGforgeNet / Fallout2_Restoration_Project

Fallout 2 Restoration Project, updated
https://forums.bgforge.net/viewforum.php?f=39
542 stars 37 forks source link

[Modoc] Jo only gives discount once #212

Closed phobos2077 closed 11 months ago

phobos2077 commented 12 months ago

What happened

After completing the Ghost Farm quest (the best solution), Jo says he'll give a discount. But it only applies immediately during the same dialog. If you talk afterwards, he will "forget" about it.

What you expected to happen

Like most other character, gdialog_set_barter_mod must be called in talk_p_proc depending on quest status (or some lvar flag) so he actually keeps his word.

phobos2077 commented 12 months ago

Fixed here: https://github.com/BGforgeNet/Fallout2_Restoration_Project/pull/197/commits/b2bca232cb39398683ee4e78cc7a83eb68377ae4

burner1024 commented 12 months ago

Isn't it the same with Renesco? Why do you think it should be remembered?

phobos2077 commented 12 months ago

Isn't it the same with Renesco? Why do you think it should be remembered?

Why not? He thanks you for saving the town from famine and says he'll supply you "at basically my cost".

This is for -75% case (note that it also "unlocks" the shelves in the current script, basically making his stock free of charge):

I wish I had more I could give you, but we're still a poor community with not much in the way of offerings. The best I can do is offer you goods at basically my cost. But I'd be honored to help keep you stocked for your journeys when I have the goods and I'm sure any of the other residents would be equally grateful if you asked them.

This is -50% case:

I wish I could give you more in the way of compensation than this, but the best I can offer you is a discount on goods. I'm not too stocked up right now, but I'm sure things will pick up around here soon and I'd be honored to help stock you up.

burner1024 commented 12 months ago

Makes sense.