BGforgeNet / Fallout2_Restoration_Project

Fallout 2 Restoration Project, updated
https://forums.bgforge.net/viewforum.php?f=39
542 stars 37 forks source link

Rearrange components for the installer #248

Closed NovaRain closed 8 months ago

NovaRain commented 8 months ago

Left - previous, Right - this PR. rpu_instx

IMO language packs are more important than other optional components, and followed by the three radio button options, then the rest of checkbox options. Come to think of it, maybe add the "fixed" flag to "Ammo damage formula" checkbox? Since it's more like language packs that the main checkbox has no actual use.

burner1024 commented 8 months ago

I think the only 2 important options are language and damage mod, so those should on top. "Default" damage option is not really necessary, I just couldn't figure out how to make a radio button without having one of its options selected by default.

NovaRain commented 8 months ago

"Default" damage option is not really necessary, I just couldn't figure out how to make a radio button without having one of its options selected by default.

You mean like this (the left one)? upui2

burner1024 commented 8 months ago

right

NovaRain commented 8 months ago

That's easy, since by default DamageFormula is already 0:

// components_ammo.iss
Name: "ammo"; Description: "Ammo damage formula";
Name: "ammo\glovz"; Description: "Glovz's"; Flags: exclusive disablenouninstallwarning;
Name: "ammo\yaam"; Description: "YAAM"; Flags: exclusive disablenouninstallwarning;

// ini_ammo.iss
FileName: "{app}\ddraw.ini"; Section: "Misc"; Key: "DamageFormula"; String: "1"; Components: ammo\glovz;
FileName: "{app}\ddraw.ini"; Section: "Misc"; Key: "DamageFormula"; String: "5"; Components: ammo\yaam;

but personally I'd take the right pic for the sake of uniformity, unless you also want to remove the default English for the language option.

burner1024 commented 8 months ago

ok