BGforgeNet / Fallout2_Restoration_Project

Fallout 2 Restoration Project, updated
https://forums.bgforge.net/viewforum.php?f=39
542 stars 37 forks source link

Description falsely claims that I crippled enemy’s right arm #256

Closed Anarcho-Bolshevik closed 6 months ago

Anarcho-Bolshevik commented 6 months ago

What happened

I critically hit somebody in her right arm, and the description told me that that crippled her arm. In reality, her arm was uncrippled.

What you expected to happen

A different message should be used for this type of critical.

Screenshot

inconsistent

Savegame

It’s kind of pointless to provide a save for this, but oh well.

do you condemn Hamas‽ do you condemn Hamas‽ do you condemn Hamas‽.zip

burner1024 commented 6 months ago

Apparently there's some mismatched messages:

[DSCD] \<novarain13> OK, here's a list I think the messages are incorrect, other humanoid/biped critter types seem OK: https://github.com/BGforgeNet/Fallout2_Unofficial_Patch/blob/master/data/text/english/game/combat.msg


Men right arm:
Message - 5014 (changed to 5010 as left arm crit?)
Failure - 5000 (changed to 5014 for actually crippled)

Women right arm: Message - 5114 (changed to 5110 as left arm crit?) Failure - 5100 (changed to 5114 for actually crippled)

Gecko right arm (using some messages from Men): Message - 6702 (nothing wrong) Failure - 5000 (changed to 5014 for actually crippled?)

Alien right arm (using some messages from Men): Message - 6806 (nothing wrong) Failure - 5000 (changed to 5014 for actually crippled?)

Giant ant right arm (using some messages from Men): Message - 6906 (nothing wrong) Failure - 5000 (changed to 5014 for actually crippled?)


> Note: If the target passes the stat check for the crit effects, "Message" will be shown. If fails and gets cripple effect applied, "Failure" will be used instead.
burner1024 commented 6 months ago

Will be fixed in sfall.

Anarcho-Bolshevik commented 6 months ago

There seems to be a similar problem when critically hitting a Super Mutant in the right arm. The description claims that it struck his temple.