search

BGforgeNet / Fallout2_Unofficial_Patch

Fallout 2 Unofficial Patch, updated
https://forums.bgforge.net/viewforum.php?f=39
131 stars 9 forks source link

fix gcbrain crash when PLANT_HAS_PART #108

Closed dzmitry-rudnouski closed 6 months ago

dzmitry-rudnouski commented 1 year ago

Talk to gcbrain when PLANT_HAS_PART - there is no reply from gcbrain and game crashes after selecting any option: scr00000 SLOT08.zip

Here is fix.

burner1024 commented 1 year ago

Better switch to using proper defines instead of giq_ and magic numbers. Why is the ANKH_GIVEN condition commented out? There's no default Reply after Reply(611), so either its condition is unnecessary, or a reply would be missing in some cases.

dzmitry-rudnouski commented 1 year ago

Corrected.

burner1024 commented 1 year ago

What about condition?

dzmitry-rudnouski commented 1 year ago

ANKH_GIVEN condition is not commented anymore. Default option after Reply(611) is NOption(233,Node999,004);

burner1024 commented 1 year ago

I mean, why do we need

   else if (global_var(GVAR_VAULT_GECKO_PLANT) < PLANT_REPAIRED) then begin
      Reply(611);

rathen than just

   else begin
      Reply(611);

?

dzmitry-rudnouski commented 1 year ago

Yes, you are right, corrected.

dzmitry-rudnouski commented 1 year ago

One more crash, now in Node003. SLOT09.zip Will be fixed in next commits.