BGforgeNet / Fallout2_Unofficial_Patch

Fallout 2 Unofficial Patch, updated
https://forums.bgforge.net/viewforum.php?f=39
135 stars 10 forks source link

dude_iq_talk is used in hcliz.ssl only #86

Closed dzmitry-rudnouski closed 2 years ago

dzmitry-rudnouski commented 2 years ago

What happened

You introduced two new variables: dude_iq_talk and dude_is_stupid_talk in 91a162ee6e68173ad6e8c9632c21d682c326101e. But they are used in scripts_src/brokhill/hcliz.ssl only.

What you expected to happen

I suppose we need to replace dude_iq and dude_is_stupid with dude_iq_talk and dude_is_stupid_talk in all scripts, no?

burner1024 commented 2 years ago

No, because that specifically determines PC eligibility for response options, and there's a lot of other IQ checks that are not about responses, and there's also non-dialogue ones. But there could be some cases where it should be replaced. If you want to give a try, be my guest.

dzmitry-rudnouski commented 2 years ago

Let's try. Here is the 1st one: #87