BGforgeNet / VScode-BGforge-MLS

BGforge MultiLanguage server
https://forums.bgforge.net/viewforum.php?f=35
Other
16 stars 5 forks source link

Object parameters should use a distinct color in .baf/.d files #1

Closed 4Luke4 closed 5 years ago

4Luke4 commented 5 years ago

If I write CheckSpellState(Myself,BERSERKER_RAGE), both the trigger and the object reference are highlighted with the same color.

It would be (much) better to have two distinct colors.........

burner1024 commented 5 years ago
  1. See this for suggestions about highlighting.
  2. It's best to include a screenshot.
  3. Easier said than done, anyway. Don't know which theme do you use, but all colors in Monokai are already used up. I think I'll change identifiers scope to constant (which they are), but that still won't allow to distinguish between objects and other ids. If you have an actual suggestion, feel free to voice it.

Edit: one thing that could be done is to make conditions the same color as actions, that'll free up a distinctive color for objects. But I'm not sure if that would be a good solution, I'd much rather prefer to keep them different.

4Luke4 commented 5 years ago

Don't know which theme do you use, but all colors in Monokai are already used up.

I was using Solarized Dark. I fixed the issue via changing the Color Theme (as you suggested). Maybe this issue only affects certain Color Themes......

burner1024 commented 5 years ago

I didn't suggest that. And it appears I misunderstood the issue. (that's where a screenshot would help). Anyway, if everything's good for you, I'll close this for now.

4Luke4 commented 5 years ago

(that's where a screenshot would help).

Here it is.

same color
burner1024 commented 5 years ago

Indeed, that's more of a theme problem. And I see that actions are colored the same as triggers in it, anyway. Unfortunately, it's not possible to cater to all themes, as they often contradict each other. For now, I'm only targeting Monokai.