search

BGforgeNet / VScode-BGforge-MLS

BGforge MultiLanguage server
https://forums.bgforge.net/viewforum.php?f=35
Other
16 stars 5 forks source link

[WeiDU] Added IWD:EE symbolic references to spell.ids #17

Closed 4Luke4 closed 4 years ago

4Luke4 commented 4 years ago

Added IWD:EE spells to Syntax Highlighting.

burner1024 commented 4 years ago

Looks good. It might be better to use a separate stanza for tokens from other games, for ease of maintenance. On the other hand, if/when IESDP gets converted into machine readable format, it'll become irrelevant anyway...

4Luke4 commented 4 years ago

It might be better to use a separate stanza for tokens from other games, for ease of maintenance.

Do you mean I should put them to the bottom of that list?

burner1024 commented 4 years ago

Yes. Something like

spell-ids-iwdee:
    name: constant.other.baf.weidu
    patterns:
      - match: \b(?i)(CLERIC_CAUSE_LIGHT_WOUNDS)\b
      ...

I'm not quite sure yet what's the best way to support multiple games syntaxes, but for now it's probably best to keep the lists separate.

4Luke4 commented 4 years ago

Yes. Something like

spell-ids-iwdee:
    name: constant.other.baf.weidu
    patterns:
      - match: \b(?i)(CLERIC_CAUSE_LIGHT_WOUNDS)\b
      ...

I'm not quite sure yet what's the best way to support multiple games syntaxes, but for now it's probably best to keep the lists separate.

OK, done.

burner1024 commented 4 years ago

Thank you, merged.