search

BGforgeNet / VScode-BGforge-MLS

BGforge MultiLanguage server
https://forums.bgforge.net/viewforum.php?f=35
Other
16 stars 5 forks source link

Fixed macro-invocation #23

Closed 4Luke4 closed 4 years ago

4Luke4 commented 4 years ago
4Luke4 commented 4 years ago

@burner1024

Also, the following two keywords are missing and they're valid both as action commands and patch commands (unless I'm missing something): LOCAL_SPRINT / LOCAL_SET.

Should I add them to weidu-tp2-action or weidu-tp2-patch?

burner1024 commented 4 years ago

Not sure what was the problem in the first place, but I guess you know better.

As for LOCAL_SPRINT/LOCAL_SET, doesn't really matter, as we color patch and action keywords the same. Although in fact this is a situation that might benefit from revisiting.

4Luke4 commented 4 years ago

Not sure what was the problem in the first place, but I guess you know better.

Unlike FUNCTIONs, MACROs don't need BEGIN / STR_VAR / INT_VAR / RET / RET_ARRAY. For instance: LAM TEST // That's it...

Also, in the current version of MLS the commands LAM, LAUNCH_ACTION_MACRO, LAUNCH_PATCH_MACRO, and LPM are not highlighted....

LAM
4Luke4 commented 4 years ago

@burner1024

Unfortunately, macro-invocation is still broken (see previous screenshot – in particular: LAM, LAUNCH_ACTION_MACRO, LAUNCH_PATCH_MACRO, and LPM are not highlighted....

burner1024 commented 4 years ago

Sorry, I screwed up and the latest commit didn't make it into release. Published an update now. It would probably be good to automate release flow, but I don't do it often enough to bother.

4Luke4 commented 4 years ago

Sorry, I screwed up and the latest commit didn't make it into release. Published an update now. It would probably be good to automate release flow, but I don't do it often enough to bother.

Sadly, it is still not working as it should... Those keywords are not highlighted....

burner1024 commented 4 years ago

Well, did it work for you in the development version? Or it isn't tested?

4Luke4 commented 4 years ago

Well, did it work for you in the development version? Or it isn't tested?

Yeah, I'm a dummy, I didn't test it enough.... Anyway, it's weird.... As I've already told you, it should be identical to function-declaration apart from BEGIN / INT_VAR / STR_VAR / RET / RET_ARRAY / END... Really, this is all you need to do:

LAM TEST // 'LAM' / 'LPM' (or the complete name LAUNCH_ACTION_MACRO / LAUNCH_PATCH_MACRO) followed by the actual name of the action/patch

Here's the link to the official documentation.

burner1024 commented 4 years ago

pushed one more version

4Luke4 commented 4 years ago

As for LOCAL_SPRINT/LOCAL_SET, doesn't really matter, as we color patch and action keywords the same...

@burner1024 Forgot to add them in the end... Please add them for the next release...