Closed 4Luke4 closed 5 years ago
Need to quote properly. This is broken yaml.
Need to quote properly. This is broken yaml.
They need to be em dashes (–)? Sorry, first time using yaml....
That'd maybe work, but it's easier to just quote the doc fully, so it's a single string:
@burner1024
Is it OK now?
No, there are still errors:
Doesn't VScode highlight that for you?
On the other hand, adding single quotes as in - INT_VAR 'special' to the new special parameter.
is not necessary.
On the other hand, adding single quotes as in
- INT_VAR 'special' to the new special parameter.
is not necessary.
I wanted to highlight the actual variable so that it properly distinguishes from the rest of the text... Did you mean this is already the case?
No, it isn't, I just meant that it's not the cause of the errors. If you think that'd be helpful, it's just as well.
No, there are still errors:
Doesn't VScode highlight that for you?
No, it doesn't. Anyway, what's the problem now? Everything seems to be quoted properly.....
Do you have yaml extension installed?
Double qoutes inside double quotes should be escaped. . "same" breaks the string.
Do you have yaml extension installed?
Installed.
Double quotes inside double quotes should be escaped.
Done.
That looks better. Did you make the dashes long after all, though? Theoretically, it should be all utf8 with no problems, but still I prefer to keep it ascii, replacing stuff like "’" and "–" with proper single quotes and dashes.
Also, you shouldn't change .tmLanguage.json files manually, these files are generated from corresponding .tmLanguage.yml by a script. (Json is just too verbose to work with).
That looks better. Did you make the dashes long after all, though?
Only for the last functions I added - I didn't go back to edit the ones already there...
Also, you shouldn't change .tmLanguage.json files manually, these files are generated from corresponding .tmLanguage.yml by a script. (Json is just too verbose to work with).
I see => reverted previous commit
@burner1024
If everything is OK now, feel free to merge...
Thank you, it is merged and published.
Thank you, it is merged and published.
No Changelog?
Moreover, I'm gonna make another pull request to add some \
(otherwise everything is on the same line...)
oh yes, added now.
Added some missing patch and macro/action functions.