BGforgeNet / bg2-tweaks-and-tricks

Tweaks and Tricks mod for Baldur's Gate 2
https://forums.bgforge.net/viewforum.php?f=31
25 stars 4 forks source link

BAND is used instead of a BOR #59

Closed GraionDilach closed 2 years ago

GraionDilach commented 2 years ago

Unless I'm overlooking something this wants to be a binary OR, since a binary AND destroys all other options in the header.

https://github.com/BGforgeNet/bg2-tweaks-and-tricks/blob/master/tnt/components/throwing_damage/main.tpa#L31

Note that this also breaks the feature on the EEs (if I read that right that it only sets a single bit) because the EEs split the strength bonus to two; see bottom of https://gibberlings3.github.io/iesdp/file_formats/ie_formats/itm_v1.htm.

burner1024 commented 2 years ago

Looks like it's should be BOR, yes. Does EE ignore bit0 altogether?

GraionDilach commented 2 years ago

Apparently yes, because I found this out only because Elestan at the Infinity Engine discord noticed that the end result does leads to him lacking strength bonus on thrown weapons.

burner1024 commented 2 years ago

Splitting them makes sense, THAC0 for throwing should be governed by Dex. I think I'll use bit0 for Classic and bit2 for EE.