search

BGmot / zabbix-module-latest-data

A Zabbix 5.4 module to group items under Monitoring -> Latest data per Tag as it used to be with Application grouping in previous versions of Zabbix
21 stars 5 forks source link

Item filter is broken #1

Closed ank-everstake closed 3 years ago

ank-everstake commented 3 years ago

When module is enabled item filter in latest data only works half the time. You can set any filter value and press apply 4 times in a row and each second time you will get the old filter back.

How to replicate:

  1. Set item filter ("Name") to value1
  2. Press Apply
  3. Set item filter ("Name") to value2
  4. Press Apply 4 times in a row - you will get : new, old, new, old
xenadmin commented 3 years ago

I tried to replicate the problem. There is a definitely a problem, but slightly different than you description. I made a video to demonstrate it: 2021-08-26 10-35-25.zip I never get it to show the old view, but it seems to switch between to filter views. When I enter two searches after another, and press apply, it switches between those two searches. EDIT: I misread your description. Yes it switches between two queries, each time we click apply. But the video might help non the less.

BGmot commented 3 years ago

Fixed by https://github.com/BGmot/zabbix-module-latest-data/commit/dda1b82cc63cfe4f27a10321ec394bf4d75960b5

ank-everstake commented 3 years ago

Seems the same bug exists in tag filter, even on v1.0.1

Here is the demo that shows it: https://user-images.githubusercontent.com/56387196/131224367-e072dd24-26b1-4052-9e81-fa147b228f4c.mp4

xenadmin commented 3 years ago

@ank-everstake Maybe you need to create a second bug report, as this one is closed?

ank-everstake commented 3 years ago

I think that we should reopen the existing as it may be connected.

BGmot commented 3 years ago

Reopened. I will take a look again.

BGmot commented 3 years ago

Finally found some time to take a look more closely and... I feel stupid - I just can't reproduce, please see attachment.

https://user-images.githubusercontent.com/1423807/131923053-d3d091e7-fbb3-4f9e-a6f6-4596286fdc7d.mp4

ank-everstake commented 3 years ago

Please check filtering not in the name field (items), but in the tag filter.

BGmot commented 3 years ago

Up to this point we talked about Name field, right? So we are all on the same page. I see the bug in Tag filter, will try to fix.

xenadmin commented 3 years ago

Up to this point we talked about Name field, right?

Yes, you are right. That's why I suggested to create a second issue, instead of re-opening this one. But to be fair @ank-everstake said his video is about tags. But most important I'm glad you will take a look at this issue =)

BGmot commented 3 years ago

Guys please test version v1.0.2.

ank-everstake commented 3 years ago

The fix seems to work ok on v5.4.4.

BGmot commented 3 years ago

Thanks for testing. Closing the issue.